fix: Add return against indexes for POS Invoice

[deepeshgarg007]

set_status is called twice while creating a POS Invoice, once on validate and once on submit. The set_status method in pos_invoice.py (similar to sales invoice) has an if block which check for return invoices to set the status as "Credit Note Issued"

The very same query in POS Invoice took around ~5 sec (depending on the no of existing POS Invoices) for a specific site. Post adding the index the POS invoice submission took 3 seconds instead of 13 seconds

Also showed up in slow query logs

[deepeshgarg007]

@Mergifyio backport version-14-hotfix version-13-hotfix

[mergify]

backport version-14-hotfix version-13-hotfix

🟠 Waiting for conditions to match

• merged [:pushpin: backport requirement]

[ankush]

Just a simple return against index should be enough. It has high enough cardinality ~= unique return.

That can be managed from doctype directly 👀

[codecov]

Codecov Report

Merging #32378 (cbfe282) into develop (106ee1b) will increase coverage by 0.16%.
The diff coverage is 50.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32378      +/-   ##
===========================================
+ Coverage    63.94%   64.11%   +0.16%     
===========================================
  Files          817      817              
  Lines        58159    58171      +12     
===========================================
+ Hits         37190    37295     +105     
+ Misses       20969    20876      -93     

Impacted Files	Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py	74.80% <50.00%> (-0.13%)	⬇️
erpnext/accounts/doctype/bank/bank.py	71.42% <0.00%> (-14.29%)	⬇️
...saction/incorrect_balance_qty_after_transaction.py	88.37% <0.00%> (-9.31%)	⬇️
...urity_shortfall/process_loan_security_shortfall.py	93.75% <0.00%> (-6.25%)	⬇️
erpnext/accounts/party.py	77.43% <0.00%> (-4.46%)	⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py	65.21% <0.00%> (-4.35%)	⬇️
...e/asset_value_adjustment/asset_value_adjustment.py	87.95% <0.00%> (-3.62%)	⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py	86.32% <0.00%> (-3.42%)	⬇️
...eorder_level/itemwise_recommended_reorder_level.py	90.74% <0.00%> (-1.86%)	⬇️
erpnext/stock/doctype/item_price/item_price.py	92.98% <0.00%> (-1.76%)	⬇️
... and 24 more

[deepeshgarg007]

@Mergifyio backport version-14-hotfix version-13-hotfix

[mergify]

backport version-14-hotfix version-13-hotfix

✅ Backports have been created

• #32383 fix: Add return against indexes for POS Invoice (backport #32378) has been created for branch version-14-hotfix
• #32384 fix: Add return against indexes for POS Invoice (backport #32378) has been created for branch version-13-hotfix