Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider overproduction percentage for WO finish button #32377

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 27, 2022

ref: ISS-22-23-02552

Steps to reproduce:

  1. Set Overproduction Percentage For Work Order to 100 in Manufacturing Settings.
  2. Create Work Order for 100 Qty.
  3. Create Material Transfer for Manufacture for 50 Qty.
  4. Create Manufacture Stock Entry for 75 Qty.

Problem: The Finish button will be hidden.

Proposed Solution: Consider Overproduction Percentage For Work Order while adding the Finish custom button.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 27, 2022
@s-aga-r s-aga-r added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #32377 (376febb) into develop (c760ca2) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32377      +/-   ##
===========================================
- Coverage    64.03%   63.97%   -0.06%     
===========================================
  Files          817      817              
  Lines        58169    58169              
===========================================
- Hits         37248    37216      -32     
- Misses       20921    20953      +32     
Impacted Files Coverage Δ
erpnext/stock/doctype/stock_entry/stock_entry.py 81.44% <ø> (ø)
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...unts/report/purchase_register/purchase_register.py 71.71% <0.00%> (-5.27%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 73.91% <0.00%> (-4.35%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 77.62% <0.00%> (-3.50%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 74.25% <0.00%> (-2.98%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 73.24% <0.00%> (-2.71%) ⬇️
...cial_statement/consolidated_financial_statement.py 89.50% <0.00%> (-0.93%) ⬇️
... and 8 more

@s-aga-r s-aga-r marked this pull request as ready for review September 27, 2022 10:42
@rohitwaghchaure rohitwaghchaure merged commit f95de1f into frappe:develop Sep 27, 2022
s-aga-r added a commit that referenced this pull request Sep 27, 2022
…-32377

fix: consider overproduction percentage for WO finish button (backport #32377)
s-aga-r added a commit that referenced this pull request Sep 27, 2022
…-32377

fix: consider overproduction percentage for WO finish button (backport #32377)
@s-aga-r s-aga-r deleted the fix/work-order/finish-button branch April 15, 2023 09:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants