Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite Item Price Stock Report queries in QB #32346

Merged

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 26, 2022

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 26, 2022
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #32346 (22299d2) into develop (4efb8b1) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32346      +/-   ##
===========================================
- Coverage    63.78%   63.69%   -0.09%     
===========================================
  Files          817      817              
  Lines        58145    58147       +2     
===========================================
- Hits         37087    37039      -48     
- Misses       21058    21108      +50     
Impacted Files Coverage Δ
.../stock/report/item_price_stock/item_price_stock.py 0.00% <0.00%> (ø)
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 81.96% <0.00%> (-4.92%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 73.24% <0.00%> (-2.71%) ⬇️
erpnext/stock/reorder_item.py 73.33% <0.00%> (-2.50%) ⬇️
.../fifo_queue_vs_qty_after_transaction_comparison.py 93.10% <0.00%> (-1.73%) ⬇️
...cial_statement/consolidated_financial_statement.py 88.58% <0.00%> (-0.93%) ⬇️
... and 16 more

@s-aga-r s-aga-r marked this pull request as ready for review September 26, 2022 11:38
@s-aga-r s-aga-r merged commit 2647018 into frappe:develop Sep 26, 2022
s-aga-r added a commit that referenced this pull request Sep 26, 2022
…-32346

refactor: rewrite `Item Price Stock Report` queries in `QB` (backport #32346)
rohitwaghchaure added a commit that referenced this pull request Sep 27, 2022
…-32346

refactor: rewrite `Item Price Stock Report` queries in `QB` (backport #32346)
@s-aga-r s-aga-r deleted the refactor/stock/report/item-price-stock-report branch April 15, 2023 09:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant