Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect gl if tax on multi currency payment entry (backport #32217) #32283

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2022

This is an automatic backport of pull request #32217 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #32283 (5ba5b7b) into version-14-hotfix (ff210c7) will decrease coverage by 0.06%.
The diff coverage is 38.88%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           version-14-hotfix   #32283      +/-   ##
=====================================================
- Coverage              63.83%   63.76%   -0.07%     
=====================================================
  Files                    816      816              
  Lines                  58117    58127      +10     
=====================================================
- Hits                   37097    37067      -30     
- Misses                 21020    21060      +40     
Impacted Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 72.79% <38.88%> (-0.56%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 50.88% <0.00%> (-11.51%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-8.19%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 86.88% <0.00%> (-3.28%) ⬇️
...next/accounts/doctype/bank_account/bank_account.py 77.27% <0.00%> (-2.28%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 49.25% <0.00%> (-1.50%) ⬇️
... and 20 more

@ruthra-kumar ruthra-kumar merged commit d7d75be into version-14-hotfix Sep 20, 2022
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-32217 branch September 20, 2022 05:40
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants