Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite Work Order Stock Report queries in QB #32153

Merged

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 10, 2022

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 10, 2022
@s-aga-r s-aga-r added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. backport version-13-hotfix labels Sep 10, 2022
@s-aga-r s-aga-r force-pushed the refactor/report/work-order-stock-report branch from 384c294 to d4c4ddd Compare September 10, 2022 11:00
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #32153 (5558191) into develop (1dce3c9) will increase coverage by 0.60%.
The diff coverage is 8.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32153      +/-   ##
===========================================
+ Coverage    63.06%   63.66%   +0.60%     
===========================================
  Files          813      813              
  Lines        57719    57724       +5     
===========================================
+ Hits         36400    36752     +352     
+ Misses       21319    20972     -347     
Impacted Files Coverage Δ
...work_order_stock_report/work_order_stock_report.py 47.50% <8.69%> (-3.93%) ⬇️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 86.88% <0.00%> (-3.28%) ⬇️
erpnext/stock/reorder_item.py 72.50% <0.00%> (-2.50%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.74% <0.00%> (-1.86%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (-1.32%) ⬇️
erpnext/support/doctype/issue/issue.py 64.28% <0.00%> (-0.96%) ⬇️
erpnext/controllers/sales_and_purchase_return.py 91.36% <0.00%> (-0.72%) ⬇️
... and 26 more

@s-aga-r s-aga-r marked this pull request as ready for review September 10, 2022 11:20
@s-aga-r s-aga-r merged commit e4a1cf0 into frappe:develop Sep 10, 2022
s-aga-r added a commit that referenced this pull request Sep 10, 2022
…-32153

refactor: rewrite Work Order Stock Report queries in QB (backport #32153)
s-aga-r added a commit that referenced this pull request Sep 21, 2022
refactor: rewrite Work Order Stock Report queries in QB (backport #32153)
@s-aga-r s-aga-r deleted the refactor/report/work-order-stock-report branch April 15, 2023 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant