Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report chart fieldtype #32146

Merged
merged 9 commits into from
Sep 26, 2022
Merged

fix: report chart fieldtype #32146

merged 9 commits into from
Sep 26, 2022

Conversation

zeta17
Copy link
Contributor

@zeta17 zeta17 commented Sep 9, 2022 •
edited by deepeshgarg007
Loading

Add fieldtype Currency to some currency-related reports

ribet1
Just add currency for fieldtype

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022 •
edited
Loading

Codecov Report

Merging #32146 (bfa77ab) into develop (8b21d27) will decrease coverage by 0.11%.
The diff coverage is 66.66%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #32146      +/-   ##
===========================================
- Coverage    64.13%   64.01%   -0.12%     
===========================================
  Files          817      817              
  Lines        58153    58154       +1     
===========================================
- Hits         37294    37227      -67     
- Misses       20859    20927      +68
Impacted Files Coverage Δ
...ort/purchase_order_trends/purchase_order_trends.py 0.00% <ø> (ø)
...projects/report/project_summary/project_summary.py 0.00% <ø> (ø)
...eport/delivery_note_trends/delivery_note_trends.py 0.00% <ø> (ø)
...purchase_receipt_trends/purchase_receipt_trends.py 0.00% <ø> (ø)
...ng/report/work_order_summary/work_order_summary.py 72.27% <50.00%> (-0.73%) ⬇️
...turing/report/job_card_summary/job_card_summary.py 71.21% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 88.88% <0.00%> (-3.71%) ⬇️
... and 27 more

@deepeshgarg007
Copy link
Member

deepeshgarg007 commented Sep 12, 2022 •
edited
Loading

@zeta17 can you please elaborate on the PR description a bit more like what problem this PR solves, and the before-after screenshots of the charts for the reviewer's understanding

@zeta17
Copy link
Contributor Author

zeta17 commented Sep 14, 2022

@zeta17 can you please elaborate on the PR description a bit more like what problem this PR solves, and the before-after screenshots of the charts for the reviewer's understanding

ribet1
Just add currency for fieldtype

@s-aga-r s-aga-r added needs-semantic-title fix-linter and removed needs-tests This PR needs automated unit-tests. labels Sep 14, 2022
s-aga-r
s-aga-r requested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@s-aga-r s-aga-r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeta17 fix the linter issue(s) and use semantic commit titles.

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022 •
edited
Loading

backport version-14-hotfix

✅ Backports have been created

@deepeshgarg007 deepeshgarg007 merged commit f41d150 into frappe:develop Sep 26, 2022
@mergify mergify bot mentioned this pull request Sep 26, 2022
Merged
deepeshgarg007 added a commit that referenced this pull request Sep 26, 2022
@deepeshgarg007
Merge pull request #32361 from frappe/mergify/bp/version-14-hotfix/pr…
408f2bd 
…-32146

fix: report chart fieldtype (backport #32146)
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r s-aga-r requested changes

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeta17 @deepeshgarg007 @s-aga-r