Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AD not getting copied from SCO while creating a Material Transfer #32109

Merged
merged 1 commit into from
Sep 7, 2022
Merged

fix: AD not getting copied from SCO while creating a Material Transfer #32109

merged 1 commit into from
Sep 7, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 7, 2022

Backport: #32106

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 7, 2022
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #32109 (b8b64ac) into version-14-hotfix (121ec83) will increase coverage by 0.49%.
The diff coverage is 58.82%.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           version-14-hotfix   #32109      +/-   ##
=====================================================
+ Coverage              63.22%   63.71%   +0.49%     
=====================================================
  Files                    813      813              
  Lines                  57632    57646      +14     
=====================================================
+ Hits                   36435    36732     +297     
+ Misses                 21197    20914     -283
Impacted Files Coverage Δ
erpnext/controllers/selling_controller.py 79.56% <ø> (ø)
erpnext/regional/saudi_arabia/utils.py 23.07% <0.00%> (ø)
...doctype/inventory_dimension/inventory_dimension.py 94.21% <28.57%> (+5.61%) ⬆️
erpnext/controllers/stock_controller.py 92.18% <100.00%> (+1.27%) ⬆️
erpnext/controllers/subcontracting_controller.py 86.72% <100.00%> (+0.02%) ⬆️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-8.19%) ⬇️
erpnext/accounts/party.py 77.71% <0.00%> (-4.18%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 60.90% <0.00%> (-0.91%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 65.15% <0.00%> (-0.76%) ⬇️
erpnext/controllers/sales_and_purchase_return.py 91.36% <0.00%> (-0.72%) ⬇️
... and 48 more

@s-aga-r s-aga-r merged commit 09d8fa4 into frappe:version-14-hotfix Sep 7, 2022
frappe-pr-bot pushed a commit that referenced this pull request Sep 13, 2022
@frappe-bot
chore(release): Bumped to Version 14.1.1
740c17c 
## [14.1.1](v14.1.0...v14.1.1) (2022-09-13)

### Bug Fixes

* AD not getting copied from SCO while creating a Material Transfer ([#32109](#32109)) ([09d8fa4](09d8fa4)), closes [#32106](#32106)
* add missing warehouse filter in BOM Stock Calculated report ([4e09203](4e09203))
* conflict ([a408722](a408722))
* consider Stock Entry purpose while getting total supplied qty ([5af0062](5af0062))
* customer code max characters limit issue ([#32177](#32177)) ([93e5100](93e5100))
* delete linked payment ledger entries no source doc deletion ([ccd0449](ccd0449))
* drop old notes column from lead and prospect ([ded6e7f](ded6e7f))
* **Employee:** shorter tab titles (backport [#32192](#32192)) ([#32193](#32193)) ([027e66f](027e66f))
* hide "Return of Components" button in closed SCO (backport [#32130](#32130)) ([#32131](#32131)) ([7840fed](7840fed))
* import error on bank statement import ([467ee97](467ee97))
* internal transfer flow ([4bac0da](4bac0da))
* inventory dimension filter's label not showing in the reort ([2d2eef6](2d2eef6))
* item wise sales register taxes and charges ([53f235b](53f235b))
* Migrate old lead notes as per the new format ([28b1d4e](28b1d4e))
* option to start reposting from repost item valuation ([6483195](6483195))
* pick_list - picked qty getting set to 1 ([3c3ab89](3c3ab89))
* promotional scheme min and max amount configuration ([702c16e](702c16e))
* QR Code multi currency issue ([d14a9a1](d14a9a1))
* Rate for internal PI have non stock UOM items ([c06e241](c06e241))
* remove EmployeeBoardingController (backport [#32139](#32139)) ([#32191](#32191)) ([944b8a0](944b8a0))
* remove multiple call to ple creation ([a2285d5](a2285d5))
* reposting not working for internal transferred purchase receipt ([7ce6729](7ce6729))
* require barcode item barcode ([#32111](#32111)) ([404668f](404668f)), closes [#31957](#31957)
* required_qty in BOM Stock Calculated report ([af883be](af883be))
* SCO Supplied Items returned-qty ([4568648](4568648))
* Set filter condition and spell in AR ([174c750](174c750))
* status filter for Subcontracting Order in Stock Entry ([844f120](844f120))
* Subcontracting Receipt GL Entries (backport [#31918](#31918)) ([#32124](#32124)) ([f2ab220](f2ab220))
* **UX:** make Item attachments public by default (backport [#32196](#32196)) ([#32197](#32197)) ([2c4867c](2c4867c))
* validate Subcontracting Order in Stock Entry ([d3cc9d4](d3cc9d4))

### Performance Improvements

* lesser SQL queries and no validation ([7bb5f6e](7bb5f6e))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@s-aga-r s-aga-r added bug and removed released labels Sep 21, 2022
@s-aga-r s-aga-r added released and removed bug labels Nov 2, 2022
@barredterra barredterra mentioned this pull request Mar 7, 2023
Closed
@s-aga-r s-aga-r deleted the backport/fix/stock-entry/subcontracting branch April 15, 2023 09:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@marination marination Awaiting requested review from marination

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-aga-r @frappe-pr-bot