Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KSA VAT report multi currency amount issue (backport #32053) #32071

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 4, 2022

This is an automatic backport of pull request #32053 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

In KSA VAT report amount is not showing correctly for multi currencies because net_amount field is fetched instead of base_net_amount

(cherry picked from commit 56d8962)
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 4, 2022
@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Merging #32071 (b96526e) into version-14-hotfix (4698dba) will increase coverage by 0.13%.
The diff coverage is 0.00%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           version-14-hotfix   #32071      +/-   ##
=====================================================
+ Coverage              63.17%   63.30%   +0.13%     
=====================================================
  Files                    813      813              
  Lines                  57604    57604              
=====================================================
+ Hits                   36391    36468      +77     
+ Misses                 21213    21136      -77     
Impacted Files Coverage Δ
erpnext/regional/report/ksa_vat/ksa_vat.py 0.00% <0.00%> (ø)
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.15% <0.00%> (-3.83%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 84.65% <0.00%> (-3.26%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 89.02% <0.00%> (-2.44%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 73.43% <0.00%> (-1.85%) ⬇️
... and 18 more

@deepeshgarg007 deepeshgarg007 merged commit d65d2f6 into version-14-hotfix Sep 4, 2022
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-32053 branch September 4, 2022 10:28
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants