Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AD not getting copied from SCO while creating a SE (backport #32004) #32007

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 29, 2022

This is an automatic backport of pull request #32004 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 29, 2022
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #32007 (17a1f5b) into version-14-hotfix (9b9df70) will decrease coverage by 0.15%.
The diff coverage is 67.34%.

@@                  Coverage Diff                  @@
##           version-14-hotfix   #32007      +/-   ##
=====================================================
- Coverage              63.34%   63.19%   -0.16%     
=====================================================
  Files                    813      813              
  Lines                  57568    57592      +24     
=====================================================
- Hits                   36469    36397      -72     
- Misses                 21099    21195      +96     
Impacted Files Coverage Δ
erpnext/stock/doctype/stock_entry/stock_entry.py 81.07% <10.00%> (+0.08%) ⬆️
...rpnext/assets/doctype/asset_repair/asset_repair.py 66.87% <75.86%> (+3.04%) ⬆️
.../report/accounts_receivable/accounts_receivable.py 71.30% <100.00%> (-0.16%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 79.81% <100.00%> (+0.07%) ⬆️
...ctype/subcontracting_order/subcontracting_order.py 90.00% <100.00%> (+0.37%) ⬆️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-37.51%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-16.84%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 89.74% <0.00%> (-7.70%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
... and 25 more

@s-aga-r s-aga-r merged commit cee867f into version-14-hotfix Aug 29, 2022
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-32004 branch August 29, 2022 10:20
frappe-pr-bot pushed a commit that referenced this pull request Aug 30, 2022
## [14.0.3](v14.0.2...v14.0.3) (2022-08-30)

### Bug Fixes

* AD not getting copied from SCO while creating a SE (backport [#32004](#32004)) ([#32007](#32007)) ([cee867f](cee867f))
* Add docstatus filter for voucher_no in Repost Item Valuation ([309da96](309da96))
* add validation for PO in Stock Entry (backport [#31974](#31974)) ([#31975](#31975)) ([4d8ced6](4d8ced6))
* default supplier not set in the PP ([4cf9fb0](4cf9fb0))
* display amount in account currency if party is supplied ([15915d7](15915d7))
* Explicitly commit "log_error" since its getting called during GET request (backport [#31952](#31952)) ([#31953](#31953)) ([362976f](362976f))
* gl entries for asset repair ([f0f7afa](f0f7afa))
* lost quotation not to expired ([8717235](8717235))
* material request connection on work order ([193502c](193502c))
* **patch:** update sla doctype directly (backport [#32014](#32014)) ([#32015](#32015)) ([1b5a1cb](1b5a1cb))
* permissions for Task Type ([#32016](#32016)) ([7ca1beb](7ca1beb))
* Purchase Order creation from Sales Order ([39ff0cc](39ff0cc))
* Purposes not set ([94ebfa7](94ebfa7))
* restrict party types to Supplier/Customer for AR/AP report ([c407d1e](c407d1e))
* Rounded total for cash and non trade discount invoices ([6c4fcd8](6c4fcd8))
* Route condition set for stock ledger (backport [#31935](#31935)) ([#31945](#31945)) ([a7d23ab](a7d23ab))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@barredterra barredterra mentioned this pull request Mar 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants