Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AD not getting copied from SCO while creating a SE #32004

Merged
merged 1 commit into from
Aug 29, 2022
Merged

fix: AD not getting copied from SCO while creating a SE #32004

merged 1 commit into from
Aug 29, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Aug 29, 2022

Source / Reference: ISS-22-23-02050

Accounting Dimensions not getting copied from Subcontracting Order while creating a Stock Entry of type Send to Subcontractor.

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Aug 29, 2022
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 29, 2022
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022 •
edited
Loading

Codecov Report

Merging #32004 (2f27b15) into develop (af5cbc8) will increase coverage by 0.31%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #32004      +/-   ##
===========================================
+ Coverage    62.79%   63.11%   +0.31%     
===========================================
  Files          813      813              
  Lines        57599    57599              
===========================================
+ Hits         36172    36356     +184     
+ Misses       21427    21243     -184
Impacted Files Coverage Δ
erpnext/stock/doctype/stock_entry/stock_entry.py 81.07% <0.00%> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
erpnext/accounts/party.py 77.43% <0.00%> (-4.74%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 89.02% <0.00%> (-2.44%) ⬇️
.../fifo_queue_vs_qty_after_transaction_comparison.py 93.10% <0.00%> (-1.73%) ⬇️
erpnext/stock/reorder_item.py 73.33% <0.00%> (-1.67%) ⬇️
... and 27 more

@s-aga-r s-aga-r force-pushed the fix/subcontracting-order/stock-entry branch from d58d7e6 to 2f27b15 Compare August 29, 2022 08:57
@s-aga-r s-aga-r merged commit 9dbaaa3 into frappe:develop Aug 29, 2022
mergify bot pushed a commit that referenced this pull request Aug 29, 2022
@s-aga-r @mergify
fix: AD not getting copied from SCO while creating a SE (#32004)
17a1f5b 
(cherry picked from commit 9dbaaa3)
@mergify mergify bot mentioned this pull request Aug 29, 2022
Merged
s-aga-r added a commit that referenced this pull request Aug 29, 2022
@mergify @s-aga-r
fix: AD not getting copied from SCO while creating a SE (backport #32004
cee867f 
) (#32007)

fix: AD not getting copied from SCO while creating a SE (#32004)

(cherry picked from commit 9dbaaa3)

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 30, 2022
@frappe-bot
chore(release): Bumped to Version 14.0.3
32abf67 
## [14.0.3](v14.0.2...v14.0.3) (2022-08-30)

### Bug Fixes

* AD not getting copied from SCO while creating a SE (backport [#32004](#32004)) ([#32007](#32007)) ([cee867f](cee867f))
* Add docstatus filter for voucher_no in Repost Item Valuation ([309da96](309da96))
* add validation for PO in Stock Entry (backport [#31974](#31974)) ([#31975](#31975)) ([4d8ced6](4d8ced6))
* default supplier not set in the PP ([4cf9fb0](4cf9fb0))
* display amount in account currency if party is supplied ([15915d7](15915d7))
* Explicitly commit "log_error" since its getting called during GET request (backport [#31952](#31952)) ([#31953](#31953)) ([362976f](362976f))
* gl entries for asset repair ([f0f7afa](f0f7afa))
* lost quotation not to expired ([8717235](8717235))
* material request connection on work order ([193502c](193502c))
* **patch:** update sla doctype directly (backport [#32014](#32014)) ([#32015](#32015)) ([1b5a1cb](1b5a1cb))
* permissions for Task Type ([#32016](#32016)) ([7ca1beb](7ca1beb))
* Purchase Order creation from Sales Order ([39ff0cc](39ff0cc))
* Purposes not set ([94ebfa7](94ebfa7))
* restrict party types to Supplier/Customer for AR/AP report ([c407d1e](c407d1e))
* Rounded total for cash and non trade discount invoices ([6c4fcd8](6c4fcd8))
* Route condition set for stock ledger (backport [#31935](#31935)) ([#31945](#31945)) ([a7d23ab](a7d23ab))
@s-aga-r s-aga-r added bug and removed backport version-14-hotfix backport to version 14 labels Sep 21, 2022
@barredterra barredterra mentioned this pull request Mar 7, 2023
Closed
@s-aga-r s-aga-r deleted the fix/subcontracting-order/stock-entry branch April 15, 2023 09:59
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-aga-r