Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete custom fields on deletion of inventory dimension #31860

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Aug 17, 2022

  • Delete custom fields on deletion of the inventory dimension
  • Removed rename functionality for the inventory dimension
  • Set value from the parent form (Using fieldname or doctype name)

image

@github-actions github-actions bot added the stock label Aug 17, 2022
@rohitwaghchaure rohitwaghchaure force-pushed the delete-custom-fields-on-dimension-delete branch 3 times, most recently from 92b43bf to f5a813a Compare August 17, 2022 06:46
@rohitwaghchaure rohitwaghchaure force-pushed the delete-custom-fields-on-dimension-delete branch from f5a813a to 0b39a01 Compare August 17, 2022 09:25
@rohitwaghchaure
Copy link
Collaborator Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

backport version-14-hotfix

✅ Backports have been created

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #31860 (0b39a01) into develop (1a2ffc7) will decrease coverage by 0.35%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##           develop   #31860      +/-   ##
===========================================
- Coverage    63.53%   63.18%   -0.36%     
===========================================
  Files          813      813              
  Lines        57506    57559      +53     
===========================================
- Hits         36536    36367     -169     
- Misses       20970    21192     +222     
Impacted Files Coverage Δ
erpnext/controllers/stock_controller.py 90.90% <87.50%> (-0.88%) ⬇️
...doctype/inventory_dimension/inventory_dimension.py 90.35% <95.00%> (+2.35%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-55.43%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-31.15%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 51.36% <0.00%> (-11.37%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
... and 44 more

@rohitwaghchaure rohitwaghchaure merged commit 396667b into frappe:develop Aug 17, 2022
rohitwaghchaure added a commit that referenced this pull request Aug 17, 2022
…-31860

fix: delete custom fields on deletion of inventory dimension (backport #31860)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant