fix(minor): don't print tax rate if its '0' #31838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextchamp-saqib
approved these changes
Aug 16, 2022
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
(cherry picked from commit 3b4c0a3)
deepeshgarg007
added a commit
that referenced
this pull request
Aug 30, 2022
…-31838 fix(minor): don't print tax rate if its '0' (backport #31838)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
# [13.37.0](v13.36.5...v13.37.0) (2022-08-30) ### Bug Fixes * Add docstatus filter for voucher_no in Repost Item Valuation ([2cf2885](2cf2885)) * Cash and non trade discount calculation ([20e9599](20e9599)) * do not clear promotion/transfer details if doc is amended ([#32000](#32000)) ([074d484](074d484)) * filter leave types and render leave application dashboard w/o from date ([#32001](#32001)) ([7686c9e](7686c9e)) * Loan Write-off for term loans ([e64e812](e64e812)) * **minor:** don't print tax rate if its '0' ([#31838](#31838)) ([a46dca5](a46dca5)) * permissions for Task Type ([#32016](#32016)) ([1157bf8](1157bf8)) * **pos:** edge case while closing pos (backport [#31748](#31748)) ([#31893](#31893)) ([261405c](261405c)) * Purposes not set ([edfaf99](edfaf99)) * Route condition set for stock ledger (backport [#31935](#31935)) ([#31946](#31946)) ([34537c9](34537c9)) * Set the condition to create a purchase receipt ([b4c992d](b4c992d)) * Test cases ([7c85b48](7c85b48)) ### Features * In BOM, Operation time can be fix (backport [#27063](#27063)) ([#31923](#31923)) ([c2b8d1b](c2b8d1b))
dottenbr
pushed a commit
to newmatik/eso-erpnext
that referenced
this pull request
Sep 6, 2022
(cherry picked from commit 3b4c0a3)
dottenbr
pushed a commit
to newmatik/eso-erpnext
that referenced
this pull request
Sep 6, 2022
# [13.37.0](frappe/erpnext@v13.36.5...v13.37.0) (2022-08-30) ### Bug Fixes * Add docstatus filter for voucher_no in Repost Item Valuation ([2cf2885](frappe@2cf2885)) * Cash and non trade discount calculation ([20e9599](frappe@20e9599)) * do not clear promotion/transfer details if doc is amended ([frappe#32000](frappe#32000)) ([074d484](frappe@074d484)) * filter leave types and render leave application dashboard w/o from date ([frappe#32001](frappe#32001)) ([7686c9e](frappe@7686c9e)) * Loan Write-off for term loans ([e64e812](frappe@e64e812)) * **minor:** don't print tax rate if its '0' ([frappe#31838](frappe#31838)) ([a46dca5](frappe@a46dca5)) * permissions for Task Type ([frappe#32016](frappe#32016)) ([1157bf8](frappe@1157bf8)) * **pos:** edge case while closing pos (backport [frappe#31748](frappe#31748)) ([frappe#31893](frappe#31893)) ([261405c](frappe@261405c)) * Purposes not set ([edfaf99](frappe@edfaf99)) * Route condition set for stock ledger (backport [frappe#31935](frappe#31935)) ([frappe#31946](frappe#31946)) ([34537c9](frappe@34537c9)) * Set the condition to create a purchase receipt ([b4c992d](frappe@b4c992d)) * Test cases ([7c85b48](frappe@7c85b48)) ### Features * In BOM, Operation time can be fix (backport [frappe#27063](frappe#27063)) ([frappe#31923](frappe#31923)) ([c2b8d1b](frappe@c2b8d1b))
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
(cherry picked from commit 3b4c0a3)
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
# [13.37.0](frappe/erpnext@v13.36.5...v13.37.0) (2022-08-30) ### Bug Fixes * Add docstatus filter for voucher_no in Repost Item Valuation ([2cf2885](frappe@2cf2885)) * Cash and non trade discount calculation ([20e9599](frappe@20e9599)) * do not clear promotion/transfer details if doc is amended ([frappe#32000](frappe#32000)) ([074d484](frappe@074d484)) * filter leave types and render leave application dashboard w/o from date ([frappe#32001](frappe#32001)) ([7686c9e](frappe@7686c9e)) * Loan Write-off for term loans ([e64e812](frappe@e64e812)) * **minor:** don't print tax rate if its '0' ([frappe#31838](frappe#31838)) ([a46dca5](frappe@a46dca5)) * permissions for Task Type ([frappe#32016](frappe#32016)) ([1157bf8](frappe@1157bf8)) * **pos:** edge case while closing pos (backport [frappe#31748](frappe#31748)) ([frappe#31893](frappe#31893)) ([261405c](frappe@261405c)) * Purposes not set ([edfaf99](frappe@edfaf99)) * Route condition set for stock ledger (backport [frappe#31935](frappe#31935)) ([frappe#31946](frappe#31946)) ([34537c9](frappe@34537c9)) * Set the condition to create a purchase receipt ([b4c992d](frappe@b4c992d)) * Test cases ([7c85b48](frappe@7c85b48)) ### Features * In BOM, Operation time can be fix (backport [frappe#27063](frappe#27063)) ([frappe#31923](frappe#31923)) ([c2b8d1b](frappe@c2b8d1b))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor UI fix
If tax rate is 0, don't print it on tax description.