fix: update To Date in Employee Work History #31811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
## [13.36.3](v13.36.2...v13.36.3) (2022-08-09) ### Bug Fixes * (india) HSN wise report ([08c69c7](08c69c7)) * add asset repair to accounting dimension list ([809d5ca](809d5ca)) * consider precision while validating advance amount against sanctioned amount ([63cd434](63cd434)) * **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31774](#31774)) ([0e46b33](0e46b33)) * f-string and where clause ([42b3959](42b3959)) * getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31768](#31768)) ([473a43b](473a43b)) * incorrect incoming rate set for inter transfer purchase receipt ([4e8b39a](4e8b39a)) * incorrect tax calculation in case of reduced payment days ([80981d0](80981d0)) * intercompany SO throws exception ([a17acfd](a17acfd)) * minor changed link ([e9e53a7](e9e53a7)) * Payment Entry button is visible even when claim is fully paid ([d820757](d820757)) * pending principal- amount ([16c94d2](16c94d2)) * **pos:** validate product bundles while submitting pos invoice (backport [#31615](#31615)) ([#31657](#31657)) ([b145fe3](b145fe3)) * specify allowed doctype in queries ([#31765](#31765)) ([0dbfb15](0dbfb15)) * statistical component showing up in salary slip ([#31746](#31746)) ([26aef4f](26aef4f)) * sum stock_value and group by warehouse ([18d93f8](18d93f8)) * taxable_value and gst_account_heads ([6c574fb](6c574fb)) * update To Date in Employee Work History ([#31811](#31811)) ([0057c10](0057c10))
|
🎉 This PR is included in version 13.36.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
## [13.36.3](frappe/erpnext@v13.36.2...v13.36.3) (2022-08-09) ### Bug Fixes * (india) HSN wise report ([08c69c7](frappe@08c69c7)) * add asset repair to accounting dimension list ([809d5ca](frappe@809d5ca)) * consider precision while validating advance amount against sanctioned amount ([63cd434](frappe@63cd434)) * **ecommerce:** remove query to non-existing field (backport [frappe#31771](frappe#31771)) ([frappe#31774](frappe#31774)) ([0e46b33](frappe@0e46b33)) * f-string and where clause ([42b3959](frappe@42b3959)) * getting error to show sales invoice group or print rep… (backport [frappe#31756](frappe#31756)) ([frappe#31768](frappe#31768)) ([473a43b](frappe@473a43b)) * incorrect incoming rate set for inter transfer purchase receipt ([4e8b39a](frappe@4e8b39a)) * incorrect tax calculation in case of reduced payment days ([80981d0](frappe@80981d0)) * intercompany SO throws exception ([a17acfd](frappe@a17acfd)) * minor changed link ([e9e53a7](frappe@e9e53a7)) * Payment Entry button is visible even when claim is fully paid ([d820757](frappe@d820757)) * pending principal- amount ([16c94d2](frappe@16c94d2)) * **pos:** validate product bundles while submitting pos invoice (backport [frappe#31615](frappe#31615)) ([frappe#31657](frappe#31657)) ([b145fe3](frappe@b145fe3)) * specify allowed doctype in queries ([frappe#31765](frappe#31765)) ([0dbfb15](frappe@0dbfb15)) * statistical component showing up in salary slip ([frappe#31746](frappe#31746)) ([26aef4f](frappe@26aef4f)) * sum stock_value and group by warehouse ([18d93f8](frappe@18d93f8)) * taxable_value and gst_account_heads ([6c574fb](frappe@6c574fb)) * update To Date in Employee Work History ([frappe#31811](frappe#31811)) ([0057c10](frappe@0057c10))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On Employee Promotion/Employee Transfer submission, internal work history gets updated in the Employee master. This updates From Date but doesn't update To Date.
The To Date functionality was never implemented in work history. When you create a promotion, the system won't really know until when is that applicable.
Solution:
Update the previous row when a new promotion/transfer happens.
Eg: Promotion 1: From Date - 01-01-2022
Promotion 2: From Date - 04-04-2022 - this will update the previous promotion's To Date to 03-04-2022