Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getting error to show sales invoice group or print rep… (backport #31756) #31767

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 3, 2022

This is an automatic backport of pull request #31756 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

fix: formatter getting error to show sales invoice group or print report.

1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken.
Error on browser console:
TypeError: Cannot read properties of undefined (reading 'indent')

2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error:
TypeError: Cannot read properties of undefined (reading 'content')

i fixed both errors and all working perfectly.

(cherry picked from commit ea88451)
@ankush ankush merged commit 53b9d61 into version-14-hotfix Aug 3, 2022
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-31756 branch August 3, 2022 05:52
frappe-pr-bot pushed a commit that referenced this pull request Aug 18, 2022
## [14.0.1](v14.0.0...v14.0.1) (2022-08-18)

### Bug Fixes

* add asset repair to accounting dimension list ([65bb1d8](65bb1d8))
* Add dimension section in subcontracting doctypes (backport [#31849](#31849)) ([#31877](#31877)) ([50ad612](50ad612))
* check item_code in all rows of po_items (backport [#31741](#31741)) ([#31842](#31842)) ([82f1dd2](82f1dd2))
* contact search in request for quotation (backport [#31828](#31828)) ([#31840](#31840)) ([74664a3](74664a3))
* delete custom fields on deletion of inventory dimension ([354a9d6](354a9d6))
* **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31773](#31773)) ([8737c10](8737c10))
* getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31767](#31767)) ([53b9d61](53b9d61))
* incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31861](#31861)) ([010a0ca](010a0ca))
* incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31864](#31864)) ([abe1894](abe1894))
* intercompany SO throws exception ([1d1f12f](1d1f12f))
* linter (backport [#31763](#31763)) ([#31766](#31766)) ([3092131](3092131))
* Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31878](#31878)) ([b637d4d](b637d4d))
* Make expense account editable in Subcontracting Receipt Item (backport [#31848](#31848)) ([#31870](#31870)) ([aa5aaa1](aa5aaa1))
* not able to issue expired batches ([ce5fc5b](ce5fc5b))
* posting_date of linked vouchers should not affect outstanding ([0faa7b0](0faa7b0))
* **projects:** Add missing comma ([623f56a](623f56a))
* set `billing_address` for purchases in `get_party_details` ([5a28ba8](5a28ba8))
* set `company_address` for purchases in `party.js` ([4c82533](4c82533))
* specify allowed doctype in queries (backport [#31761](#31761)) ([#31764](#31764)) ([6dce122](6dce122))
* Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31873](#31873)) ([04d3571](04d3571))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@barredterra barredterra mentioned this pull request Mar 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants