-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getting error to show sales invoice group or print rep… #31756
Merged
ankush
merged 1 commit into
frappe:develop
from
HarryPaulo:fix-view-and-print-gross-profit
Aug 3, 2022
Merged
fix: getting error to show sales invoice group or print rep… #31756
ankush
merged 1 commit into
frappe:develop
from
HarryPaulo:fix-view-and-print-gross-profit
Aug 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort. 1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken. Error on browser console: TypeError: Cannot read properties of undefined (reading 'indent') 2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error: TypeError: Cannot read properties of undefined (reading 'content') i fixed both errors and all working perfectly.
Linters is faill but i didnt commited the failled file. |
ankush
approved these changes
Aug 3, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
fix: formatter getting error to show sales invoice group or print report. 1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken. Error on browser console: TypeError: Cannot read properties of undefined (reading 'indent') 2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error: TypeError: Cannot read properties of undefined (reading 'content') i fixed both errors and all working perfectly. (cherry picked from commit ea88451)
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
fix: formatter getting error to show sales invoice group or print report. 1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken. Error on browser console: TypeError: Cannot read properties of undefined (reading 'indent') 2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error: TypeError: Cannot read properties of undefined (reading 'content') i fixed both errors and all working perfectly. (cherry picked from commit ea88451)
ankush
pushed a commit
that referenced
this pull request
Aug 3, 2022
…#31756) (#31767) fix: getting error to show sales invoice group or print rep… (#31756) fix: formatter getting error to show sales invoice group or print report. 1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken. Error on browser console: TypeError: Cannot read properties of undefined (reading 'indent') 2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error: TypeError: Cannot read properties of undefined (reading 'content') i fixed both errors and all working perfectly. (cherry picked from commit ea88451) Co-authored-by: HarryPaulo <paulo_fabris@hotmail.com>
ankush
pushed a commit
that referenced
this pull request
Aug 3, 2022
…#31756) (#31768) fix: getting error to show sales invoice group or print rep… (#31756) fix: formatter getting error to show sales invoice group or print report. 1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken. Error on browser console: TypeError: Cannot read properties of undefined (reading 'indent') 2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error: TypeError: Cannot read properties of undefined (reading 'content') i fixed both errors and all working perfectly. (cherry picked from commit ea88451) Co-authored-by: HarryPaulo <paulo_fabris@hotmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
## [13.36.3](v13.36.2...v13.36.3) (2022-08-09) ### Bug Fixes * (india) HSN wise report ([08c69c7](08c69c7)) * add asset repair to accounting dimension list ([809d5ca](809d5ca)) * consider precision while validating advance amount against sanctioned amount ([63cd434](63cd434)) * **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31774](#31774)) ([0e46b33](0e46b33)) * f-string and where clause ([42b3959](42b3959)) * getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31768](#31768)) ([473a43b](473a43b)) * incorrect incoming rate set for inter transfer purchase receipt ([4e8b39a](4e8b39a)) * incorrect tax calculation in case of reduced payment days ([80981d0](80981d0)) * intercompany SO throws exception ([a17acfd](a17acfd)) * minor changed link ([e9e53a7](e9e53a7)) * Payment Entry button is visible even when claim is fully paid ([d820757](d820757)) * pending principal- amount ([16c94d2](16c94d2)) * **pos:** validate product bundles while submitting pos invoice (backport [#31615](#31615)) ([#31657](#31657)) ([b145fe3](b145fe3)) * specify allowed doctype in queries ([#31765](#31765)) ([0dbfb15](0dbfb15)) * statistical component showing up in salary slip ([#31746](#31746)) ([26aef4f](26aef4f)) * sum stock_value and group by warehouse ([18d93f8](18d93f8)) * taxable_value and gst_account_heads ([6c574fb](6c574fb)) * update To Date in Employee Work History ([#31811](#31811)) ([0057c10](0057c10))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
## [14.0.1](v14.0.0...v14.0.1) (2022-08-18) ### Bug Fixes * add asset repair to accounting dimension list ([65bb1d8](65bb1d8)) * Add dimension section in subcontracting doctypes (backport [#31849](#31849)) ([#31877](#31877)) ([50ad612](50ad612)) * check item_code in all rows of po_items (backport [#31741](#31741)) ([#31842](#31842)) ([82f1dd2](82f1dd2)) * contact search in request for quotation (backport [#31828](#31828)) ([#31840](#31840)) ([74664a3](74664a3)) * delete custom fields on deletion of inventory dimension ([354a9d6](354a9d6)) * **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31773](#31773)) ([8737c10](8737c10)) * getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31767](#31767)) ([53b9d61](53b9d61)) * incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31861](#31861)) ([010a0ca](010a0ca)) * incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31864](#31864)) ([abe1894](abe1894)) * intercompany SO throws exception ([1d1f12f](1d1f12f)) * linter (backport [#31763](#31763)) ([#31766](#31766)) ([3092131](3092131)) * Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31878](#31878)) ([b637d4d](b637d4d)) * Make expense account editable in Subcontracting Receipt Item (backport [#31848](#31848)) ([#31870](#31870)) ([aa5aaa1](aa5aaa1)) * not able to issue expired batches ([ce5fc5b](ce5fc5b)) * posting_date of linked vouchers should not affect outstanding ([0faa7b0](0faa7b0)) * **projects:** Add missing comma ([623f56a](623f56a)) * set `billing_address` for purchases in `get_party_details` ([5a28ba8](5a28ba8)) * set `company_address` for purchases in `party.js` ([4c82533](4c82533)) * specify allowed doctype in queries (backport [#31761](#31761)) ([#31764](#31764)) ([6dce122](6dce122)) * Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31873](#31873)) ([04d3571](04d3571))
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
…frappe#31756) (frappe#31768) fix: getting error to show sales invoice group or print rep… (frappe#31756) fix: formatter getting error to show sales invoice group or print report. 1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken. Error on browser console: TypeError: Cannot read properties of undefined (reading 'indent') 2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error: TypeError: Cannot read properties of undefined (reading 'content') i fixed both errors and all working perfectly. (cherry picked from commit ea88451) Co-authored-by: HarryPaulo <paulo_fabris@hotmail.com>
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
## [13.36.3](frappe/erpnext@v13.36.2...v13.36.3) (2022-08-09) ### Bug Fixes * (india) HSN wise report ([08c69c7](frappe@08c69c7)) * add asset repair to accounting dimension list ([809d5ca](frappe@809d5ca)) * consider precision while validating advance amount against sanctioned amount ([63cd434](frappe@63cd434)) * **ecommerce:** remove query to non-existing field (backport [frappe#31771](frappe#31771)) ([frappe#31774](frappe#31774)) ([0e46b33](frappe@0e46b33)) * f-string and where clause ([42b3959](frappe@42b3959)) * getting error to show sales invoice group or print rep… (backport [frappe#31756](frappe#31756)) ([frappe#31768](frappe#31768)) ([473a43b](frappe@473a43b)) * incorrect incoming rate set for inter transfer purchase receipt ([4e8b39a](frappe@4e8b39a)) * incorrect tax calculation in case of reduced payment days ([80981d0](frappe@80981d0)) * intercompany SO throws exception ([a17acfd](frappe@a17acfd)) * minor changed link ([e9e53a7](frappe@e9e53a7)) * Payment Entry button is visible even when claim is fully paid ([d820757](frappe@d820757)) * pending principal- amount ([16c94d2](frappe@16c94d2)) * **pos:** validate product bundles while submitting pos invoice (backport [frappe#31615](frappe#31615)) ([frappe#31657](frappe#31657)) ([b145fe3](frappe@b145fe3)) * specify allowed doctype in queries ([frappe#31765](frappe#31765)) ([0dbfb15](frappe@0dbfb15)) * statistical component showing up in salary slip ([frappe#31746](frappe#31746)) ([26aef4f](frappe@26aef4f)) * sum stock_value and group by warehouse ([18d93f8](frappe@18d93f8)) * taxable_value and gst_account_heads ([6c574fb](frappe@6c574fb)) * update To Date in Employee Work History ([frappe#31811](frappe#31811)) ([0057c10](frappe@0057c10))
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken .
https://prnt.sc/7iOqo6wr8y5C
Error on browser console:
TypeError: Cannot read properties of undefined (reading 'indent')
2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error:
TypeError: Cannot read properties of undefined (reading 'content')
i fixed both errors and all working perfectly.