Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pos): validate product bundles while submitting pos invoice #31615

Merged

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Jul 18, 2022

Sub-Items of Product Bundles weren't validated for stock quantity while submitting POS Invoices

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #31615 (9796043) into develop (5a3999e) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #31615      +/-   ##
===========================================
- Coverage    63.17%   63.04%   -0.14%     
===========================================
  Files          813      813              
  Lines        57505    57502       -3     
===========================================
- Hits         36331    36253      -78     
- Misses       21174    21249      +75     
Impacted Files Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 74.93% <ø> (+0.06%) ⬆️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-31.15%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 65.67% <0.00%> (-2.71%) ⬇️
... and 17 more

@nextchamp-saqib nextchamp-saqib merged commit 2eaa8b1 into frappe:develop Jul 21, 2022
mergify bot pushed a commit that referenced this pull request Jul 21, 2022
frappe-pr-bot pushed a commit that referenced this pull request Aug 9, 2022
## [13.36.3](v13.36.2...v13.36.3) (2022-08-09)

### Bug Fixes

* (india) HSN wise report ([08c69c7](08c69c7))
* add asset repair to accounting dimension list ([809d5ca](809d5ca))
* consider precision while validating advance amount against sanctioned amount ([63cd434](63cd434))
* **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31774](#31774)) ([0e46b33](0e46b33))
* f-string and where clause ([42b3959](42b3959))
* getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31768](#31768)) ([473a43b](473a43b))
* incorrect incoming rate set for inter transfer purchase receipt ([4e8b39a](4e8b39a))
* incorrect tax calculation in case of reduced payment days ([80981d0](80981d0))
* intercompany SO throws exception ([a17acfd](a17acfd))
* minor changed link ([e9e53a7](e9e53a7))
* Payment Entry button is visible even when claim is fully paid ([d820757](d820757))
* pending principal- amount ([16c94d2](16c94d2))
* **pos:** validate product bundles while submitting pos invoice (backport [#31615](#31615)) ([#31657](#31657)) ([b145fe3](b145fe3))
* specify allowed doctype in queries ([#31765](#31765)) ([0dbfb15](0dbfb15))
* statistical component showing up in salary slip ([#31746](#31746)) ([26aef4f](26aef4f))
* sum stock_value and group by warehouse ([18d93f8](18d93f8))
* taxable_value and gst_account_heads ([6c574fb](6c574fb))
* update To Date in Employee Work History ([#31811](#31811)) ([0057c10](0057c10))
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this pull request Jan 26, 2023
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this pull request Jan 26, 2023
## [13.36.3](frappe/erpnext@v13.36.2...v13.36.3) (2022-08-09)

### Bug Fixes

* (india) HSN wise report ([08c69c7](frappe@08c69c7))
* add asset repair to accounting dimension list ([809d5ca](frappe@809d5ca))
* consider precision while validating advance amount against sanctioned amount ([63cd434](frappe@63cd434))
* **ecommerce:** remove query to non-existing field (backport [frappe#31771](frappe#31771)) ([frappe#31774](frappe#31774)) ([0e46b33](frappe@0e46b33))
* f-string and where clause ([42b3959](frappe@42b3959))
* getting error to show sales invoice group or print rep… (backport [frappe#31756](frappe#31756)) ([frappe#31768](frappe#31768)) ([473a43b](frappe@473a43b))
* incorrect incoming rate set for inter transfer purchase receipt ([4e8b39a](frappe@4e8b39a))
* incorrect tax calculation in case of reduced payment days ([80981d0](frappe@80981d0))
* intercompany SO throws exception ([a17acfd](frappe@a17acfd))
* minor changed link ([e9e53a7](frappe@e9e53a7))
* Payment Entry button is visible even when claim is fully paid ([d820757](frappe@d820757))
* pending principal- amount ([16c94d2](frappe@16c94d2))
* **pos:** validate product bundles while submitting pos invoice (backport [frappe#31615](frappe#31615)) ([frappe#31657](frappe#31657)) ([b145fe3](frappe@b145fe3))
* specify allowed doctype in queries ([frappe#31765](frappe#31765)) ([0dbfb15](frappe@0dbfb15))
* statistical component showing up in salary slip ([frappe#31746](frappe#31746)) ([26aef4f](frappe@26aef4f))
* sum stock_value and group by warehouse ([18d93f8](frappe@18d93f8))
* taxable_value and gst_account_heads ([6c574fb](frappe@6c574fb))
* update To Date in Employee Work History ([frappe#31811](frappe#31811)) ([0057c10](frappe@0057c10))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant