Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: if() to CASE WHEN #31360

Merged
merged 6 commits into from
Jun 17, 2022
Merged

refactor: if() to CASE WHEN #31360

merged 6 commits into from
Jun 17, 2022

Conversation

c-p-b
Copy link
Contributor

@c-p-b c-p-b commented Jun 14, 2022

instead of using MariaDB IF() function, we change this to be CASE WHEN, which is also supported syntax by Postgres.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #31360 (159e5d0) into develop (10583eb) will decrease coverage by 0.11%.
The diff coverage is 97.14%.

@@             Coverage Diff             @@
##           develop   #31360      +/-   ##
===========================================
- Coverage    63.64%   63.53%   -0.12%     
===========================================
  Files          984      984              
  Lines        67562    67573      +11     
===========================================
- Hits         43001    42933      -68     
- Misses       24561    24640      +79     
Impacted Files Coverage Δ
...xt/accounts/doctype/journal_entry/journal_entry.py 68.95% <ø> (ø)
erpnext/accounts/utils.py 70.32% <ø> (ø)
.../report/procurement_tracker/procurement_tracker.py 90.19% <ø> (ø)
erpnext/controllers/accounts_controller.py 85.57% <ø> (-0.24%) ⬇️
.../hr/doctype/leave_application/leave_application.py 82.37% <ø> (ø)
erpnext/hr/utils.py 76.40% <ø> (ø)
...cturing/doctype/production_plan/production_plan.py 74.86% <ø> (ø)
...ext/manufacturing/doctype/work_order/work_order.py 78.16% <ø> (-0.15%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 77.49% <ø> (ø)
erpnext/payroll/doctype/salary_slip/salary_slip.py 87.14% <ø> (+0.24%) ⬆️
... and 60 more

@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jun 17, 2022
@ankush ankush added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Jun 17, 2022
@ankush ankush merged commit ea28ed1 into frappe:develop Jun 17, 2022
adityahase added a commit to adityahase/erpnext that referenced this pull request Aug 17, 2022
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
Added with #31360

(cherry picked from commit d38778e)

# Conflicts:
#	erpnext/projects/doctype/project/project.py
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
Added with #31360

(cherry picked from commit d38778e)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. stock
Projects
Development

Successfully merging this pull request may close these issues.

2 participants