Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor Non Profit fixes #31110

Merged
merged 2 commits into from
May 24, 2022
Merged

fix: minor Non Profit fixes #31110

merged 2 commits into from
May 24, 2022

Conversation

ruchamahabal
Copy link
Member

  • If a non-administrator creates a Membership, it resets the From Date to the current date, not letting the user create backdated memberships. Remove this default.
  • If donations and subscriptions are set up in the same dashboard, membership payments also trigger a payment webhook. In order to differentiate, there is already a check for RP's auto-generated description but if subscriptions are configured using subscription links, RP doesn't send descriptions. Use invoice_id to ignore such payments instead.

@ruchamahabal
fix: remove bad default for Membership From Date
34928d2
@ruchamahabal
fix: don't capture payments with invoice_id as donations
168a9d4 
- if donations and subscriptions are set up in the same dashboard, membership payments also trigger payment webhook

- in order to differentiate there is already a check for RP's auto generated description but if subscriptions are configured using subscription links, RP doesn't send descriptions

- use invoice_id to ignore such payments instead
@ruchamahabal ruchamahabal merged commit a071095 into frappe:version-13-hotfix May 24, 2022
@ruchamahabal ruchamahabal deleted the fix-npo-membership branch May 24, 2022 13:08
@ruchamahabal ruchamahabal mentioned this pull request May 25, 2022
Merged
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruchamahabal @frappe-pr-bot