-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove leave policy assignment creation patch #31097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ruchamahabal
commented
May 23, 2022
•
edited
Loading
edited
- This patch was written in feat: Leave policy assignment #23112 where leaves were granted explicitly after creating policy assignments.
- This was refactored in feat: Leave Policy Assignment Refactor #24327 where this redundant "Grant Leaves" button was removed and leaves were granted on submission of policy assignment.
- This patch doesn't seem to be required since policy assignments never used to get created automatically.
- Moreover, creating assignments without Leave Period information, breaks this patch a lot during migrations and there is no other way to patch this.
- If successful, it just allocates leaves arbitrarily on migration based on defaults set in the employee master which is also not correct.
Codecov Report
@@ Coverage Diff @@
## develop #31097 +/- ##
===========================================
- Coverage 63.34% 63.04% -0.30%
===========================================
Files 986 986
Lines 67367 67358 -9
===========================================
- Hits 42673 42468 -205
- Misses 24694 24890 +196
|
Will look into the failing test |
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
(cherry picked from commit d4b9cc0) # Conflicts: # erpnext/patches.txt
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
# [13.33.0](v13.32.0...v13.33.0) (2022-06-07) ### Bug Fixes * Close unsecured terms loans ([d6d1d79](d6d1d79)) * Consider only Approved leave applications in LWP, Employee Benefit calculations ([7f84c86](7f84c86)) * display currencies in validation message. ([ef22337](ef22337)) * incorrect billed_qty in sales order analysis report when multiple delivery notes for item (backport [#31194](#31194)) ([#31250](#31250)) ([3b1f6da](3b1f6da)) * incorrect LWP calculation for half days in employee benefit application ([10f0c93](10f0c93)) * **India:** GSTIN filter in GSTR-1 report ([abe9fe7](abe9fe7)) * **India:** Supplies from composite dealer not showing up ([15712c7](15712c7)) * **job card:** only hold during draft state (backport [#31243](#31243)) ([#31249](#31249)) ([a7fc278](a7fc278)) * **Leave Application:** 'Cancelled' status shown as 'Open' in list view ([8b48d45](8b48d45)) * leave balance for earned leaves in backdated Leave Application dashboard (backport [#31253](#31253)) ([#31256](#31256)) ([a22d92f](a22d92f)) * only fetch membership expiry if not already set in `member.js` ([#31259](#31259)) ([d433784](d433784)) * Parent dimension filters in orders ([b3cbcd8](b3cbcd8)) * Pluralize year text instead of optional bracket (backport [#31210](#31210)) ([#31212](#31212)) ([b31709c](b31709c)) * re-validate warehouse after 'update items' (backport [#31203](#31203)) ([#31206](#31206)) ([3a718c7](3a718c7)) * remove leave policy assignment creation patch (backport [#31097](#31097)) ([#31204](#31204)) ([4aeb448](4aeb448)) * Remove redundant query ([3c4cf59](3c4cf59)) * Reverse provisional entries on Purchase Invoice cancel ([1fba432](1fba432)) * **Sales Register:** incorrect query with dimensions (backport [#31242](#31242)) ([#31251](#31251)) ([0badfc8](0badfc8)) * Simply cancel reverse entries ([100b8d9](100b8d9)) ### Features * **india:** Improve E-way Bill Cancellation. ([#31088](#31088)) ([622d25e](622d25e))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.