-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(UX): Salary Slip creation and submission via background job in Payroll Entry #31074
Merged
ruchamahabal
merged 12 commits into
frappe:develop
from
ruchamahabal:fix-salary-slip-bg-job
Jun 2, 2022
Merged
refactor(UX): Salary Slip creation and submission via background job in Payroll Entry #31074
ruchamahabal
merged 12 commits into
frappe:develop
from
ruchamahabal:fix-salary-slip-bg-job
Jun 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in the background
- Add status for Queued/Failed - log errors and show corrective actions in payroll entry
Codecov Report
@@ Coverage Diff @@
## develop #31074 +/- ##
===========================================
+ Coverage 63.25% 63.46% +0.20%
===========================================
Files 986 986
Lines 67372 67406 +34
===========================================
+ Hits 42619 42781 +162
+ Misses 24753 24625 -128
|
- since it doesn't return any value
…e on submit/cancel
- fix multicurrency test, remove redundant doc creation
af0b1c8
to
1d3427c
Compare
4a18102
to
3593277
Compare
d543eb9
to
653d634
Compare
924a1be
to
247c6a2
Compare
91deb8c
to
3e28f9e
Compare
- remove savepoints since submission should stop if any error occurs - refactor variable naming and msgprints - test Salary Slip creation failure - fix(test): explicitly commit after payroll entry creation so that the first salary slip creation failure does not rollback the Payroll Entry insert
3e28f9e
to
d641f26
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
submission-before.mp4
Solution
Add a status field to Payroll Entry: Draft/Queued/Failed/Submitted/Cancelled
Inform the user that the creation/submission is queued
On failure, show the error message for corrective actions within the payroll entry
failure-correction.mp4