Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chart data for monthly periodicity in Cash Flow report #31039

Merged
merged 4 commits into from
May 25, 2022
Merged

fix: Chart data for monthly periodicity in Cash Flow report #31039

merged 4 commits into from
May 25, 2022

Conversation

AlexandreLumertz
Copy link
Contributor

fix: Only 'total' value was reported in the chart.
In this case, only the first period was graphed.

Problem: https://prnt.sc/jYG3plkV-XnN

fix: Only 'total' value was reported in the chart.
In this case, only the first period was graphed.
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #31039 (991ece1) into develop (3714e36) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #31039      +/-   ##
===========================================
- Coverage    63.07%   62.88%   -0.20%     
===========================================
  Files          985      985              
  Lines        67272    67272              
===========================================
- Hits         42431    42303     -128     
- Misses       24841    24969     +128     
Impacted Files Coverage Δ
erpnext/accounts/report/cash_flow/cash_flow.py 42.85% <ø> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 59.64% <0.00%> (-26.32%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-22.96%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 89.74% <0.00%> (-7.70%) ⬇️
.../fifo_queue_vs_qty_after_transaction_comparison.py 86.20% <0.00%> (-6.90%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
erpnext/accounts/party.py 78.09% <0.00%> (-4.62%) ⬇️
... and 20 more

@AlexandreLumertz AlexandreLumertz changed the title Only 'total' value was reported in the chart. fix: Only 'total' value was reported in the chart. May 16, 2022
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented May 25, 2022

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@deepeshgarg007 deepeshgarg007 changed the title fix: Only 'total' value was reported in the chart. fix: Chart data for monthly periodicity in Cash Flow report May 25, 2022
@deepeshgarg007 deepeshgarg007 merged commit c5e922c into frappe:develop May 25, 2022
@mergify
Copy link
Contributor

mergify bot commented May 25, 2022

backport version-13-hotfix

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 25, 2022
fix: Chart data for monthly periodicity in Cash Flow report
(cherry picked from commit c5e922c)
deepeshgarg007 added a commit that referenced this pull request May 25, 2022
…-31039

fix: Chart data for monthly periodicity in Cash Flow report (backport #31039)
frappe-pr-bot pushed a commit that referenced this pull request May 26, 2022
# [13.31.0](v13.30.0...v13.31.0) (2022-05-26)

### Bug Fixes

* Account currency validation for first transaction ([228f10b](228f10b))
* Add party account validation for journal entry ([7f853b1](7f853b1))
* always update item_name for stock entry (backport [#31068](#31068)) ([#31071](#31071)) ([f519dc6](f519dc6))
* change project's actual_start_date fieldtype from Data to Date (backport [#31085](#31085)) ([#31135](#31135)) ([8c2f203](8c2f203))
* Chart data for monthly periodicity in Cash Flow report ([#31039](#31039)) ([f14e9b7](f14e9b7))
* corrective job card creation (backport [#31083](#31083)) ([#31084](#31084)) ([c17c260](c17c260))
* don't capture payments with invoice_id as donations ([168a9d4](168a9d4))
* employee advance status update on return via additional salary ([d59c3d2](d59c3d2))
* Handle missing HSN Codes ([ce3a21e](ce3a21e))
* Healthcare module accounting test cases ([09a42a1](09a42a1))
* **India:** Async issue in company address trigger ([2ea3318](2ea3318))
* **india:** error while parsing e-invoice ([#31061](#31061)) ([1461d66](1461d66))
* **india:** eway bill cancel api is disabled ([#31060](#31060)) ([95491e1](95491e1))
* Job Card excess transfer behaviour (backport [#31054](#31054)) ([#31096](#31096)) ([3984f04](3984f04))
* Leave Encashment calculations (backport [#31062](#31062)) ([#31091](#31091)) ([ba76b64](ba76b64))
* Loan Doc query in Bank Reconciliation Statement ([611d1af](611d1af))
* Loan repayment entries for payroll payable account ([ea6d754](ea6d754))
* multiple entries for same payment term ([90b1147](90b1147))
* Party account validation in JV ([d10c2e5](d10c2e5))
* payments duplicate on pos closing entry (backport [#30976](#30976)) ([#31005](#31005)) ([0efbabe](0efbabe))
* **pos:** paid amount calculation for multicurrency invoice ([#31122](#31122)) ([98eb7da](98eb7da))
* remove bad default for Membership From Date ([34928d2](34928d2))
* Remove validation from Journal Entry ([4ca6cdc](4ca6cdc))
* replace document states with list settings ([78e9e66](78e9e66))
* timesheet fetching in sales invoice ([216c32f](216c32f))
* Use directly <a> and style it as button instead of using button ([0ab9fc0](0ab9fc0))

### Features

* **Employee Advance:** add 'Returned' and 'Partly Claimed and Returned' status ([42e7a86](42e7a86))

### Reverts

* Revert "fix: Add party account validation for journal entry" ([9d43a90](9d43a90))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants