Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Employee Status filter in leave balance reports #31013

Merged
merged 3 commits into from
May 13, 2022

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented May 13, 2022

Problem:

In the leave balance reports: Employee Leave Balance and Employee Leave Balance Summary, only "Active" employees are shown by default. If HR wants to check balances for employees with Inactive/Left status for Leave Encashment or other purposes, they cannot.

image

image

Solution:

Added a filter for Employee Status which defaults to "Active" since only active employees were shown in the report:

image

image

This filter has been added to both the reports.

no-docs Just added a filter (self-explanatory)

@ruchamahabal ruchamahabal requested a review from pateljannat as a code owner May 13, 2022 15:02
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 13, 2022
@ruchamahabal ruchamahabal removed the needs-tests This PR needs automated unit-tests. label May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #31013 (260cfa5) into develop (39fad39) will decrease coverage by 0.16%.
The diff coverage is 94.73%.

@@             Coverage Diff             @@
##           develop   #31013      +/-   ##
===========================================
- Coverage    62.97%   62.81%   -0.17%     
===========================================
  Files          984      984              
  Lines        67186    67204      +18     
===========================================
- Hits         42311    42214      -97     
- Misses       24875    24990     +115     
Impacted Files Coverage Δ
erpnext/controllers/queries.py 62.31% <ø> (ø)
erpnext/stock/doctype/bin/bin.py 96.22% <66.66%> (-1.78%) ⬇️
...xt/accounts/doctype/payment_entry/payment_entry.py 69.09% <100.00%> (+0.24%) ⬆️
erpnext/accounts/general_ledger.py 94.53% <100.00%> (+0.19%) ⬆️
...t/employee_leave_balance/employee_leave_balance.py 94.54% <100.00%> (+0.10%) ⬆️
..._balance_summary/employee_leave_balance_summary.py 95.34% <100.00%> (+0.22%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 51.58% <0.00%> (-10.86%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
... and 22 more

@ruchamahabal ruchamahabal merged commit ead08aa into frappe:develop May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant