-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: subscription refactor #30963
feat: subscription refactor #30963
Conversation
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Hi, this is the most important doctype/function for any service company. And it is becoming more and more common, so not only does a refactor make sense, but it already marks a horizon with improvements. |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #30963 +/- ##
===========================================
+ Coverage 64.11% 64.59% +0.48%
===========================================
Files 785 788 +3
Lines 60780 61371 +591
===========================================
+ Hits 38970 39645 +675
+ Misses 21810 21726 -84
|
* feat: subscription refactor * fix: linter changes * chore: linter changes * chore: linter changes * chore: Update tests * chore: Remove commits --------- Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> (cherry picked from commit 3880560) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/purchase_invoice.json # erpnext/accounts/doctype/sales_invoice/sales_invoice.json # erpnext/accounts/doctype/subscription/subscription.py # erpnext/accounts/doctype/subscription/test_subscription.py # erpnext/patches.txt
is_postpaid_to_invoice
andis_prepaid_to_invoice
.