Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subtract change_amount from paid_amount field on POS Register #30922

Merged
merged 1 commit into from
May 9, 2022
Merged

fix: subtract change_amount from paid_amount field on POS Register #30922

merged 1 commit into from
May 9, 2022

Conversation

HarryPaulo
Copy link
Contributor

@HarryPaulo HarryPaulo commented May 6, 2022

When a sale is made and the difference amount is not allocated as change.

Example 1:
Sales: $9.90
Client pays $10 and receives change.
Change Amout: $0.1
Write Off Amout: $0

Report before my change show:
grand_total: $9.90
paid_amount: $10

With my change, show de real paid amout like show on pos close entry:
grand_total: $9.90
paid_amount: $9.90

Example 2:
Sales: $9.90
Customer pays $10 and will not receive change.
Change Amout: 0
Write Off Amout: $0.1

Rerpot before my change and with my changes show:
grand_total: $9.90
paid_amount: $10

With this we will have the real value received!

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #30922 (f5e11e4) into develop (dafdc9b) will increase coverage by 1.30%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #30922      +/-   ##
===========================================
+ Coverage    61.77%   63.08%   +1.30%     
===========================================
  Files         1079      983      -96     
  Lines        69701    67062    -2639     
===========================================
- Hits         43057    42305     -752     
+ Misses       26644    24757    -1887     
Impacted Files Coverage Δ
...pnext/accounts/report/pos_register/pos_register.py 0.00% <ø> (ø)
...xt/hr/doctype/employee_checkin/employee_checkin.py 94.26% <100.00%> (+0.62%) ⬆️
erpnext/hr/doctype/shift_type/shift_type.py 86.41% <100.00%> (+0.34%) ⬆️
erpnext/domains/retail.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/domains/services.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/domains/distribution.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/domains/manufacturing.py 0.00% <0.00%> (-100.00%) ⬇️
..._integrations/connectors/woocommerce_connection.py 0.00% <0.00%> (-77.09%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 28.84% <0.00%> (-55.77%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
... and 155 more

@nextchamp-saqib nextchamp-saqib merged commit ebbe27c into frappe:develop May 9, 2022
mergify bot pushed a commit that referenced this pull request May 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants