Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Period Closing Voucher is considering GL entries with is_cancelled=1 #30865

Merged
merged 2 commits into from
May 2, 2022
Merged

fix: Period Closing Voucher is considering GL entries with is_cancelled=1 #30865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e0dee3
fix: Period Closing Voucher - Period Closing Voucher is considering G…
SherinKR May 2, 2022
681529c
fix: condition
nextchamp-saqib May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def get_pl_balances(self):
sum(t1.debit_in_account_currency) - sum(t1.credit_in_account_currency) as bal_in_account_currency,
sum(t1.debit) - sum(t1.credit) as bal_in_company_currency
from `tabGL Entry` t1, `tabAccount` t2
where t1.account = t2.name and t2.report_type = 'Profit and Loss'
where t1.is_cancelled = 0 and t1.account = t2.name and t2.report_type = 'Profit and Loss'
and t2.docstatus < 2 and t2.company = %s
and t1.posting_date between %s and %s
group by t1.account, {dimension_fields}
Expand Down