Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multi currency opening invoices #30843

Merged

Conversation

deepeshgarg007
Copy link
Member

image

The user gets the above error when while making an opening invoice against a customer having a default current other than the company currency

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #30843 (a8452c2) into develop (1622faa) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #30843      +/-   ##
===========================================
- Coverage    61.77%   61.66%   -0.11%     
===========================================
  Files         1079     1079              
  Lines        69701    69701              
===========================================
- Hits         43055    42982      -73     
- Misses       26646    26719      +73     
Impacted Files Coverage Δ
...ice_creation_tool/opening_invoice_creation_tool.py 62.91% <100.00%> (ø)
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-31.15%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 51.58% <0.00%> (-11.77%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...t/accounts/report/sales_register/sales_register.py 70.76% <0.00%> (-7.02%) ⬇️
...unts/report/purchase_register/purchase_register.py 71.71% <0.00%> (-6.58%) ⬇️
erpnext/accounts/party.py 78.09% <0.00%> (-4.33%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 74.25% <0.00%> (-3.97%) ⬇️
... and 22 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit dafdc9b into frappe:develop Apr 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Apr 29, 2022
…-30843

fix: Multi currency opening invoices (backport #30843)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant