Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create new item instead of using with _Test Item #30827

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Apr 27, 2022

Unnecessary dependency causes flake in stock test. The test was reposting all
entries for item just to test some behavior that is best tested on a
newly created item anyway.

Unnecessary depedency causes flake in stock. The test was reposting all
entries for item just to test some behaviour that is best tested on a
newly created item _anyway_.
@ankush ankush merged commit 777f020 into frappe:develop Apr 27, 2022
@ankush ankush deleted the test_state_cleanup branch April 27, 2022 12:17
mergify bot pushed a commit that referenced this pull request Apr 27, 2022
Unnecessary dependency causes flake in stock. The test was reposting all
entries for item just to test some behavior that is best tested on a
newly created item _anyway_.

(cherry picked from commit 777f020)
ankush added a commit that referenced this pull request Apr 28, 2022
Unnecessary dependency causes flake in stock. The test was reposting all
entries for item just to test some behavior that is best tested on a
newly created item _anyway_.

(cherry picked from commit 777f020)
mergify bot added a commit that referenced this pull request Apr 28, 2022
…) (#30829)

This is an automatic backport of pull request #30827 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant