fix: batch_no filtering not working when batch no is also a number in…

[ankush]

Problem: Automatic fetching of serial nos fails if the batch filter is a batch number that's also a number in scientific notation. E.g. 3709E93 which gets converted to 3709 * 10^93 by safe_json_loads.

Fix: reuse batch query string if JSON parsed data isn't a list.

======================================================================
 FAIL  test_auto_fetch (erpnext.stock.doctype.serial_no.test_serial_no.TestSerialNo)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/frappe-bench/apps/erpnext/erpnext/stock/doctype/serial_no/test_serial_no.py", line 319, in test_auto_fetch
    self.assertEqual(fetched_sr, sorted(expected_serials))
    batch = '3709E93'
    batch1 = '3709E93'
    batch2 = '401DA09'
    batch_wise_serials = {'3709E93': ['TEST0000001', 'TEST0000002', 'TEST0000003', 'TEST0000004', 'TEST0000005'], '401DA09': ['TEST0000006', 'TEST0000007', 'TEST0000008', 'TEST0000009', 'TEST0000010']}
    expected_serials = ['TEST0000001', 'TEST0000002', 'TEST0000003', 'TEST0000004', 'TEST0000005']
    fetched_sr = []
    first_fetch = ['TEST0000001', 'TEST0000002', 'TEST0000003', 'TEST0000004', 'TEST0000005']
    in1 = <StockEntry: MAT-STE-2022-00024 docstatus=1>
    in2 = <StockEntry: MAT-STE-2022-00025 docstatus=1>
    item_code = '8c7de508cbda010d'
    partial_fetch = ['TEST0000001', 'TEST0000002']
    remaining = ['TEST0000003', 'TEST0000004', 'TEST0000005']
    self = <erpnext.stock.doctype.serial_no.test_serial_no.TestSerialNo testMethod=test_auto_fetch>
    warehouse = '_Test Warehouse - _TC'
AssertionError: Lists differ: [] != ['TEST0000001', 'TEST0000002', 'TEST0000003', 'TEST0000004', 'TEST0000005']

Second list contains 5 additional elements.
First extra element 0:
'TEST0000001'

- []
+ ['TEST0000001', 'TEST0000002', 'TEST0000003', 'TEST0000004', 'TEST0000005']

[ankush]

(not adding test for this crazy edge case 😆 this was caught via tests only)

[codecov]

Codecov Report

Merging #30770 (5354611) into develop (5660b33) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #30770      +/-   ##
===========================================
+ Coverage    61.40%   61.50%   +0.10%     
===========================================
  Files         1080     1080              
  Lines        69493    69493              
===========================================
+ Hits         42669    42745      +76     
+ Misses       26824    26748      -76     

Impacted Files	Coverage Δ
erpnext/regional/india/e_invoice/utils.py	42.57% <ø> (ø)
...eport/sales_order_analysis/sales_order_analysis.py	73.33% <ø> (ø)
...xt/hr/doctype/shift_assignment/shift_assignment.py	90.77% <100.00%> (+15.04%)	⬆️
erpnext/stock/doctype/serial_no/serial_no.py	89.22% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py	31.32% <0.00%> (-53.02%)	⬇️
erpnext/stock/doctype/manufacturer/manufacturer.py	80.00% <0.00%> (-20.00%)	⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py	85.96% <0.00%> (-10.53%)	⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py	65.21% <0.00%> (-4.35%)	⬇️
...vs_serial_no_count/stock_qty_vs_serial_no_count.py	92.85% <0.00%> (-3.58%)	⬇️
...e/asset_value_adjustment/asset_value_adjustment.py	86.04% <0.00%> (-3.49%)	⬇️
... and 43 more