-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: First preference to parent cost center rather than round off cost center #30754
Merged
deepeshgarg007
merged 6 commits into
frappe:develop
from
deepeshgarg007:round_off_account_cost_center
Apr 25, 2022
Merged
fix: First preference to parent cost center rather than round off cost center #30754
deepeshgarg007
merged 6 commits into
frappe:develop
from
deepeshgarg007:round_off_account_cost_center
Apr 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #30754 +/- ##
===========================================
+ Coverage 61.67% 61.71% +0.03%
===========================================
Files 1079 1079
Lines 69542 69583 +41
===========================================
+ Hits 42893 42944 +51
+ Misses 26649 26639 -10
|
9d16335
to
783793d
Compare
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Apr 25, 2022
…-30754 fix: First preference to parent cost center rather than round off cost center (backport #30754)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios where the user maintains branch-wise cost centers. In such scenarios, they also want the cost center in the rounding adjustment entry to be passed branch-wise rather than a single cost center. Sales and Purchase Invoice already have a cost center field that users can update, this cost center is also updated branch wise, hence this cost center should be given first preference for rounding adjustment entry cost center before the round off cost center
Todo