Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: First preference to parent cost center rather than round off cost center #30754

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 20, 2022

There are scenarios where the user maintains branch-wise cost centers. In such scenarios, they also want the cost center in the rounding adjustment entry to be passed branch-wise rather than a single cost center. Sales and Purchase Invoice already have a cost center field that users can update, this cost center is also updated branch wise, hence this cost center should be given first preference for rounding adjustment entry cost center before the round off cost center

Todo

  • Consider custom accounting dimensions for rounding adjustment entry as well

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Apr 20, 2022
@deepeshgarg007 deepeshgarg007 marked this pull request as ready for review April 21, 2022 09:53
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #30754 (3fa1c63) into develop (deed970) will increase coverage by 0.03%.
The diff coverage is 95.00%.

@@             Coverage Diff             @@
##           develop   #30754      +/-   ##
===========================================
+ Coverage    61.67%   61.71%   +0.03%     
===========================================
  Files         1079     1079              
  Lines        69542    69583      +41     
===========================================
+ Hits         42893    42944      +51     
+ Misses       26649    26639      -10     
Impacted Files Coverage Δ
erpnext/accounts/general_ledger.py 94.33% <94.44%> (-0.02%) ⬇️
...ounts/doctype/purchase_invoice/purchase_invoice.py 82.48% <100.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 78.30% <100.00%> (-0.09%) ⬇️
...rpnext/hr/doctype/travel_request/travel_request.py 0.00% <0.00%> (-80.00%) ⬇️
...ext/education/doctype/fee_schedule/fee_schedule.py 0.00% <0.00%> (-22.99%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 80.24% <0.00%> (-7.00%) ⬇️
...t/accounts/report/sales_register/sales_register.py 71.92% <0.00%> (-5.85%) ⬇️
...next/accounts/doctype/bank_account/bank_account.py 77.27% <0.00%> (-2.28%) ⬇️
... and 23 more

@deepeshgarg007 deepeshgarg007 force-pushed the round_off_account_cost_center branch from 9d16335 to 783793d Compare April 23, 2022 16:10
@deepeshgarg007 deepeshgarg007 removed dont-merge needs-tests This PR needs automated unit-tests. labels Apr 25, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2022

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Apr 25, 2022
…-30754

fix: First preference to parent cost center rather than round off cost center (backport #30754)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant