Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont reassign mutable (list) to a different field (backport #30634) #30635

Merged
merged 3 commits into from
Apr 7, 2022
Merged

fix: dont reassign mutable (list) to a different field (backport #30634) #30635

merged 3 commits into from
Apr 7, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 7, 2022 •
edited by sagarvora
Loading

This is an automatic backport of pull request #30634 done by Mergify.
Conflicts fixed.

sagarvora added 2 commits April 7, 2022 11:56
@sagarvora
fix: dont reassign mutable (list) to a different field
17ac45c 
(cherry picked from commit fa4f57f)

# Conflicts:
#	erpnext/crm/doctype/opportunity/opportunity.py
@sagarvora
fix: define tax_columns below consistency
3ea1bf2 
(cherry picked from commit 3b4754f)
@mergify mergify bot added the conflicts label Apr 7, 2022
@sagarvora sagarvora removed their assignment Apr 7, 2022
@sagarvora sagarvora requested a review from ankush April 7, 2022 12:07
@ankush ankush added dont-merge squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. and removed dont-merge labels Apr 7, 2022
@ankush ankush force-pushed the mergify/bp/version-13-hotfix/pr-30634 branch from 857eb61 to dbe5e91 Compare April 7, 2022 13:02
@mergify mergify bot merged commit 4a7ae5c into version-13-hotfix Apr 7, 2022
@mergify mergify bot deleted the mergify/bp/version-13-hotfix/pr-30634 branch April 7, 2022 13:30
@commit-lint commit-lint bot mentioned this pull request Apr 22, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

Assignees
No one assigned
Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankush @sagarvora