Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont reassign mutable (list) to a different field #30634

Merged
merged 2 commits into from
Apr 7, 2022
Merged

fix: dont reassign mutable (list) to a different field #30634

merged 2 commits into from
Apr 7, 2022

Conversation

sagarvora
Copy link
Collaborator

@sagarvora sagarvora commented Apr 7, 2022 •
edited
Loading

Search regex for those interested: [^=]*=[^=]+=.*\[\]

Identified here: https://github.com/frappe/erpnext/runs/5866861172?check_suite_focus=true#step:12:843

@sagarvora sagarvora requested review from ankush and removed request for ruchamahabal, nextchamp-saqib, pateljannat and deepeshgarg007 April 7, 2022 11:24
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #30634 (3b4754f) into develop (c9d6618) will increase coverage by 0.07%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop   #30634      +/-   ##
===========================================
+ Coverage    60.94%   61.01%   +0.07%     
===========================================
  Files         1083     1083              
  Lines        69215    69217       +2     
===========================================
+ Hits         42182    42235      +53     
+ Misses       27033    26982      -51
Impacted Files Coverage Δ
erpnext/crm/doctype/opportunity/opportunity.py 70.23% <0.00%> (-0.33%) ⬇️
...unts/report/purchase_register/purchase_register.py 80.26% <100.00%> (ø)
erpnext/selling/doctype/customer/customer.py 74.01% <100.00%> (+0.08%) ⬆️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 66.21% <0.00%> (-2.71%) ⬇️
...next/accounts/doctype/bank_account/bank_account.py 77.27% <0.00%> (-2.28%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 56.71% <0.00%> (-1.50%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 80.24% <0.00%> (-1.24%) ⬇️
erpnext/stock/reorder_item.py 76.92% <0.00%> (-0.86%) ⬇️
... and 23 more

@sagarvora sagarvora merged commit 26abfd4 into frappe:develop Apr 7, 2022
@sagarvora sagarvora deleted the fix-mutable-reassignment branch April 7, 2022 11:55
@mergify mergify bot mentioned this pull request Apr 7, 2022
Merged
@sagarvora sagarvora mentioned this pull request Apr 7, 2022
Merged
mergify bot added a commit that referenced this pull request Apr 7, 2022
@mergify
fix: dont reassign mutable (list) to a different field (backport #30634…
4a7ae5c 
…) (#30635)

This is an automatic backport of pull request #30634 done by [Mergify](https://mergify.com).
Conflicts fixed.
@commit-lint commit-lint bot mentioned this pull request Apr 22, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagarvora @ankush