Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback to item_name if description is not found #30619

Merged
merged 1 commit into from
Apr 7, 2022
Merged

fix: fallback to item_name if description is not found #30619

merged 1 commit into from
Apr 7, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Apr 7, 2022

The description field is mandatory which causes this error while creating SO / SI from APIs. Added item_name fallback in line with the behavior of item doctype.

Screenshot 2022-04-07 at 10 51 12 AM

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Apr 7, 2022
@ankush ankush added backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Apr 7, 2022
@ankush ankush force-pushed the item_description branch from 7fc98e0 to 3037cb5 Compare April 7, 2022 05:52
@ankush ankush force-pushed the item_description branch from 3037cb5 to 573523e Compare April 7, 2022 06:55
@ankush ankush merged commit e4c6d6a into frappe:develop Apr 7, 2022
@ankush ankush deleted the item_description branch April 7, 2022 07:23
mergify bot pushed a commit that referenced this pull request Apr 7, 2022
@ankush
fix: strip html tags before checking for empty description (#30619)
daa1eed 
(cherry picked from commit e4c6d6a)

# Conflicts:
#	erpnext/stock/doctype/item/test_item.py
@mergify mergify bot mentioned this pull request Apr 7, 2022
Merged
ankush added a commit that referenced this pull request Apr 7, 2022
@mergify @ankush
fix: fallback to item_name if description is not found (backport #30619…
af039be 
…) (#30622)

* fix: strip html tags before checking for empty description (#30619)

(cherry picked from commit e4c6d6a)

# Conflicts:
#	erpnext/stock/doctype/item/test_item.py

* fix: resolve conflicts

Co-authored-by: Ankush Menat <ankush@frappe.io>
@commit-lint commit-lint bot mentioned this pull request Apr 22, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ankush