Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(india): minor e-invoicing fixes #30553

Merged
merged 4 commits into from
Apr 5, 2022
Merged

fix(india): minor e-invoicing fixes #30553

merged 4 commits into from
Apr 5, 2022

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Apr 4, 2022 •
edited
Loading

Fixes:

  • If the mode of payment > 18 characters, the e-invoice portal throws an error
    • Since the mode of payment info is not mandatory, it can be omitted.
  • Fix JSON parse error while previewing GST E-Invoice before generating IRN
    CleanShot 2022-04-04 at 14 38 29@2x

@nextchamp-saqib
fix(india): cannot generate e-invoice for is_pos invoices
0c26f9a 
* If mode of payment > 18 characters, the e-invoice portal throws error
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 4, 2022
@nextchamp-saqib nextchamp-saqib added backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Apr 4, 2022
@nextchamp-saqib nextchamp-saqib changed the title fix(india): cannot generate e-invoice for is_pos invoices fix(india): minor e-invoicing fixes Apr 4, 2022
@nextchamp-saqib
Copy link
Member Author

Unrelated tests failing

@nextchamp-saqib nextchamp-saqib merged commit 1bc0557 into frappe:develop Apr 5, 2022
@mergify mergify bot mentioned this pull request Apr 5, 2022
Merged
nextchamp-saqib added a commit that referenced this pull request Apr 5, 2022
@nextchamp-saqib
Merge pull request #30580 from frappe/mergify/bp/version-13-hotfix/pr…
072c3d2 
…-30553

fix(india): minor e-invoicing fixes (backport #30553)
@deepeshgarg007 deepeshgarg007 mentioned this pull request Apr 6, 2022
Merged
@mergify mergify bot mentioned this pull request May 19, 2022
Merged
nextchamp-saqib pushed a commit that referenced this pull request May 19, 2022
@mergify
fix(india): minor e-invoicing fixes (backport #30553) (#31067)
432210d
@DaizyModi DaizyModi mentioned this pull request Jun 16, 2022
Closed
25 tasks
@vorasmit vorasmit mentioned this pull request Jun 17, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

Assignees
No one assigned
Labels
backport version-13-hotfix old-backport version-12-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nextchamp-saqib