Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pos): do not reset search input on item selection #30537

Merged

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Apr 1, 2022

Consider a case where a user has several items named AA1...AA20
For creating an invoice like

  • 3x AA1
  • 4x AA12
  • 5x AA14

The user has to

  • Search for AA1, then click on the item, then click on the cart and edit the quantity to 3
  • Search for AA12, then click on the item, then click on the cart and edit the quantity to 4
  • Search for AA14, then click on the item, then click on the cart and edit the quantity to 5

This PR aims to improve that by not resetting the search input field on item selection
So now,
The user has to

  • Search for AA1 (AA12 & AA14 should also be displayed)
    • Click on AA1 3 times
    • Click on AA12 4 times
    • Click on AA14 5 times

Provided "Auto-add filtered item to the cart" is disabled

@nextchamp-saqib nextchamp-saqib merged commit fed6603 into frappe:develop Apr 4, 2022
mergify bot pushed a commit that referenced this pull request Apr 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant