Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(India): Tax fetching based on tax category #30500

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Mar 30, 2022

Taxes based on templates linked via tax category was not getting fetched properly. This was replicable only for Indian companies as this was conflicting with regional tax fetching logic for India.

Scenario when the issue is replicated

  1. Make a customer with GST address and GSTIN
  2. Add tax category to customer master and sales taxes and charges template
  3. Try creating an invoice against that customer

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 30, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2022

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Apr 1, 2022
…-30500

fix(India): Tax fetching based on tax category (backport #30500)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant