Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credit limit validation in delivery note #30470

Merged

Conversation

nextchamp-saqib
Copy link
Member

Problem:

  • Create a Customer with a Credit Limit of 200 and "Bypass Credit Limit at SO" checked
  • Create a Sales Order for 200 against that customer
  • Create a Sales Invoice against the Sales Order
  • Create a Delivery Note against the Sales Invoice or Sales Order
  • On DN submission user gets an error "Credit Limit exhausted"
    • Fix: Since DN is against SO / SI, the credit limit shouldn't be validated

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #30470 (c122882) into develop (760e68b) will increase coverage by 23.98%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##           develop   #30470       +/-   ##
============================================
+ Coverage    36.80%   60.79%   +23.98%     
============================================
  Files         1081     1082        +1     
  Lines        68920    69061      +141     
============================================
+ Hits         25367    41986    +16619     
+ Misses       43553    27075    -16478     
Impacted Files Coverage Δ
...pnext/stock/doctype/delivery_note/delivery_note.py 68.91% <0.00%> (+8.42%) ⬆️
...item_wise_sales_history/item_wise_sales_history.py 32.35% <100.00%> (+32.35%) ⬆️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 89.02% <0.00%> (-2.44%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-2.33%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 78.10% <0.00%> (-0.60%) ⬇️
erpnext/e_commerce/product_data_engine/query.py 75.36% <0.00%> (ø)
... and 448 more

@nextchamp-saqib nextchamp-saqib merged commit 87dc9c6 into frappe:develop Mar 30, 2022
nextchamp-saqib added a commit that referenced this pull request Mar 30, 2022
…-30470

fix: credit limit validation in delivery note (backport #30470)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant