Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: submit Work Order when “Make Serial No / Batch from Work Order” is enabled #30468

Merged
merged 2 commits into from
Mar 30, 2022
Merged

fix: submit Work Order when “Make Serial No / Batch from Work Order” is enabled #30468

merged 2 commits into from
Mar 30, 2022

Conversation

akurungadam
Copy link
Contributor

Cannot submit Work Order when Make Serial No / Batch from Work Order option is set in Manufacturing Settings. This happens only when submitting from listview, the job_card_qty is a float field and casting it to int fixes the issue

@ankush ankush merged commit 3f37179 into frappe:version-13-hotfix Mar 30, 2022
mergify bot pushed a commit that referenced this pull request Mar 30, 2022
@akurungadam
fix: cast array slice index integer while splitting serial_nos array (#…
346c828 
…30468)

(cherry picked from commit 3f37179)
@mergify mergify bot mentioned this pull request Mar 30, 2022
Closed
@ankush ankush added backport develop instructs mergify to frontport PR to develop branch and removed backport version-13-hotfix labels Mar 30, 2022
mergify bot pushed a commit that referenced this pull request Mar 30, 2022
@akurungadam
fix: cast array slice index integer while splitting serial_nos array (#…
a7435df 
…30468)

(cherry picked from commit 3f37179)
@mergify mergify bot mentioned this pull request Mar 30, 2022
Merged
ankush pushed a commit that referenced this pull request Mar 30, 2022
@mergify @akurungadam
fix: cast array slice index integer while splitting serial_nos array (#…
89a9afa 
…30468) (#30496)

(cherry picked from commit 3f37179)

Co-authored-by: Anoop <anoop@earthianslive.com>
@deepeshgarg007 deepeshgarg007 mentioned this pull request Apr 6, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport develop instructs mergify to frontport PR to develop branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akurungadam @ankush