Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use name for links not item_code #30462

Merged
merged 1 commit into from
Mar 29, 2022
Merged

fix: use name for links not item_code #30462

merged 1 commit into from
Mar 29, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Mar 29, 2022

All link fields are "linked" using name field and not the way name field is defined which in this case is item_code

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 29, 2022
@ankush ankush merged commit 76dce2e into frappe:develop Mar 29, 2022
@ankush ankush added backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Mar 29, 2022
mergify bot pushed a commit that referenced this pull request Mar 29, 2022
@ankush
fix: use name for links not item_code (#30462)
02f56e9 
(cherry picked from commit 76dce2e)

# Conflicts:
#	erpnext/selling/report/item_wise_sales_history/item_wise_sales_history.py
@mergify mergify bot mentioned this pull request Mar 29, 2022
Merged
ankush added a commit that referenced this pull request Mar 29, 2022
@mergify @ankush
fix: use name for links not item_code (backport #30462) (#30463)
00ad515 
* fix: use `name` for links not `item_code` (#30462)

(cherry picked from commit 76dce2e)

# Conflicts:
#	erpnext/selling/report/item_wise_sales_history/item_wise_sales_history.py

* fix: conflicts

Co-authored-by: Ankush Menat <ankush@frappe.io>
@deepeshgarg007 deepeshgarg007 mentioned this pull request Apr 6, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ankush