Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: call repost directly during tests #30277

Merged
merged 1 commit into from
Mar 16, 2022
Merged

refactor: call repost directly during tests #30277

merged 1 commit into from
Mar 16, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Mar 16, 2022

enqueue(now=frappe.flags.in_test) is always true in test, this change avoids confusion.

@ankush
refactor: call repost directly during tests
141a1e0 
enqueue(now=frappe.flags.in_test) is always true in test, this change avoids
confusion.
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 16, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Mar 16, 2022
@ankush ankush merged commit 76187d1 into frappe:develop Mar 16, 2022
mergify bot pushed a commit that referenced this pull request Mar 16, 2022
@ankush
refactor: call repost directly during tests (#30277)
723524e 
enqueue(now=frappe.flags.in_test) is always true in test, this change avoids
confusion.

(cherry picked from commit 76187d1)
@mergify mergify bot mentioned this pull request Mar 16, 2022
Merged
ankush added a commit that referenced this pull request Mar 16, 2022
@mergify @ankush
refactor: call repost directly during tests (#30277) (#30279)
0becc1e 
enqueue(now=frappe.flags.in_test) is always true in test, this change avoids
confusion.

(cherry picked from commit 76187d1)

Co-authored-by: Ankush Menat <ankush@frappe.io>
@ankush ankush deleted the repost_on_submit branch March 17, 2022 05:37
KrithiRamani pushed a commit to KrithiRamani/erpnext that referenced this pull request Mar 28, 2022
@ankush @KrithiRamani
refactor: call repost directly during tests (frappe#30277)
4e2bb2e 
enqueue(now=frappe.flags.in_test) is always true in test, this change avoids
confusion.
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ankush