Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect payable amount for loan closure #30191

Merged
merged 4 commits into from
Apr 2, 2022
Merged

fix: incorrect payable amount for loan closure #30191

merged 4 commits into from
Apr 2, 2022

Conversation

abhinavxd
Copy link
Contributor

  • For Loan closure, the penalty amount should also be added to the payable amount

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #30191 (8c76a76) into develop (1d2e9e8) will increase coverage by 7.18%.
The diff coverage is 100.00%.

❗ Current head 8c76a76 differs from pull request most recent head 7e185fb. Consider uploading reports for the commit 7e185fb to get more accurate results

@@             Coverage Diff             @@
##           develop   #30191      +/-   ##
===========================================
+ Coverage    53.06%   60.25%   +7.18%     
===========================================
  Files         1083     1084       +1     
  Lines        69124    68509     -615     
===========================================
+ Hits         36682    41278    +4596     
+ Misses       32442    27231    -5211     
Impacted Files Coverage Δ
...anagement/doctype/loan_repayment/loan_repayment.py 89.18% <100.00%> (+20.75%) ⬆️
...ation_account/exchange_rate_revaluation_account.py 0.00% <0.00%> (-100.00%) ⬇️
...xt/stock/dashboard/warehouse_capacity_dashboard.py 0.00% <0.00%> (-77.50%) ⬇️
...ange_rate_revaluation/exchange_rate_revaluation.py 0.00% <0.00%> (-48.98%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 45.83% <0.00%> (-36.96%) ⬇️
...t/accounts/report/general_ledger/general_ledger.py 60.06% <0.00%> (-9.56%) ⬇️
...cturing/doctype/bom_update_tool/bom_update_tool.py 73.68% <0.00%> (-7.57%) ⬇️
.../hr/doctype/leave_application/leave_application.py 74.34% <0.00%> (-7.21%) ⬇️
erpnext/stock/doctype/serial_no/serial_no.py 81.23% <0.00%> (-5.89%) ⬇️
erpnext/accounts/report/utils.py 75.36% <0.00%> (-5.80%) ⬇️
... and 662 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Apr 2, 2022
…-30191

fix: incorrect payable amount for loan closure (backport #30191)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants