Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust heart icon to v14 icons in frappe (make consistent with v13) & misc fix #29953

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

marination
Copy link
Collaborator

Before:

  • Screenshot 2022-02-23 at 12 23 23 AM In navbar
  • Screenshot 2022-02-23 at 12 23 37 AM inactive in listing
  • Screenshot 2022-02-23 at 12 23 44 AM active in listing

After

  • Screenshot 2022-02-23 at 12 17 54 AM In navbar
  • Screenshot 2022-02-23 at 12 18 46 AM inactive in listing
  • Screenshot 2022-02-23 at 12 18 55 AM active in listing

Fixes only applicable to develop due to some v14 changes, backport not needed

… to accomodate changes in frappe icon

- `icon-heart` got a stroke colour that needs to be overriden via var `icon-stroke
- Use `icon-heart` instead of `icon-heart-active` as the latter has a color fill now
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 22, 2022
@marination
Copy link
Collaborator Author

failing tests are unrelated

@marination marination merged commit 856d3f6 into frappe:develop Feb 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant