Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: trigger generate schedule when any change made in items table #29874

Merged
merged 16 commits into from
Apr 12, 2022

Conversation

noahjacob
Copy link
Contributor

Issue

  • When changing any field in the items table, the user would need to click on generate schedule to get the new schedule with the appropriate changes.

maint_gen_bug

Changes

  • Generate schedule now automatically triggers when making changes in fields like serial_no, sales_person, etc.

maint_gen_fix

Closes - #29564

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #29874 (319545e) into develop (96fc6ad) will decrease coverage by 0.18%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop   #29874      +/-   ##
===========================================
- Coverage    60.89%   60.71%   -0.19%     
===========================================
  Files         1083     1083              
  Lines        69111    69122      +11     
===========================================
- Hits         42085    41965     -120     
- Misses       27026    27157     +131     
Impacted Files Coverage Δ
...ctype/maintenance_schedule/maintenance_schedule.py 86.47% <91.66%> (+0.63%) ⬆️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-23.73%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 80.19% <0.00%> (-10.90%) ⬇️
...unts/report/purchase_register/purchase_register.py 70.39% <0.00%> (-9.87%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 51.58% <0.00%> (-9.51%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
... and 37 more

@ankush ankush merged commit 8261b2b into frappe:develop Apr 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serial Number not auto - updated on save in Maintenance Schedule
3 participants