Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes in TDS payable monthly report #29791

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Feb 14, 2022

  • Cancelled entries were being considered in TDS Payable monthly report, which led to wrong amount being visible in the reports
  • Supplier wise filtering fix and considers debit entries (TDS Refund)
  • Ignore TDS payment entries

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #29791 (2ff6b35) into develop (86ef932) will increase coverage by 0.60%.
The diff coverage is 0.00%.

❗ Current head 2ff6b35 differs from pull request most recent head 04cbde2. Consider uploading reports for the commit 04cbde2 to get more accurate results

@@             Coverage Diff             @@
##           develop   #29791      +/-   ##
===========================================
+ Coverage    58.87%   59.47%   +0.60%     
===========================================
  Files         1112     1108       -4     
  Lines        69553    68895     -658     
===========================================
+ Hits         40948    40975      +27     
+ Misses       28605    27920     -685     
Impacted Files Coverage Δ
.../report/tds_payable_monthly/tds_payable_monthly.py 0.00% <0.00%> (ø)
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
erpnext/portal/utils.py 23.18% <0.00%> (-5.80%) ⬇️
.../manufacturing/report/bom_explorer/bom_explorer.py 94.44% <0.00%> (-5.56%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-2.28%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 84.55% <0.00%> (-0.82%) ⬇️
... and 40 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2022

backport version-13-hotfix version-13-pre-release

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Feb 15, 2022
…-29791

fix: Fixes in TDS payable monthly report (backport #29791)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant