Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable rounded total in opening invoice creation tool #29789

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

nextchamp-saqib
Copy link
Member

If you try to create an Invoice with grand total of 1000.01, and the Global Default has unchecked Disabled Rounded Total, then you'll face an error:

CleanShot 2022-02-14 at 18 32 56

Solution:
Disable Rounded Total for invoices created from Opening Invoice Creation Tool

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #29789 (a8309c5) into develop (60b55f0) will increase coverage by 10.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop   #29789       +/-   ##
============================================
+ Coverage    48.86%   59.06%   +10.19%     
============================================
  Files         1112     1112               
  Lines        69567    69567               
============================================
+ Hits         33995    41088     +7093     
+ Misses       35572    28479     -7093     
Impacted Files Coverage Δ
...ice_creation_tool/opening_invoice_creation_tool.py 62.66% <ø> (ø)
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
.../manufacturing/report/bom_explorer/bom_explorer.py 94.44% <0.00%> (-5.56%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-2.28%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 86.88% <0.00%> (-1.64%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 84.55% <0.00%> (-0.82%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-0.78%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 79.16% <0.00%> (-0.60%) ⬇️
... and 224 more

@nextchamp-saqib nextchamp-saqib merged commit 67a7802 into frappe:develop Feb 15, 2022
deepeshgarg007 added a commit that referenced this pull request Feb 15, 2022
…-29789

fix: disable rounded total in opening invoice creation tool (backport #29789)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant