-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Generate Warehouse wise FIFO Queue always and later aggregate if required #29788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Back to back stock recos cause incorrect qty calculation across warehouses - Hard to differentiate how much of the qty is reset by the reco - Maintain Queue and balances warehouse wise and later aggregate for accurate values
Codecov Report
@@ Coverage Diff @@
## develop #29788 +/- ##
===========================================
+ Coverage 51.82% 59.54% +7.72%
===========================================
Files 1108 1108
Lines 68893 68908 +15
===========================================
+ Hits 35703 41033 +5330
+ Misses 33190 27875 -5315
|
Patch test breaking due to framework |
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Feb 14, 2022
…-29788 fix: Generate Warehouse wise FIFO Queue always and later aggregate if required (backport #29788)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Consider the following ledger with different warehouses:
show_warehouse_wise_stock
is disabled, ignores warehouse completely and maintains only item wise dataFIFOSlots
does not know/care about which warehouse this reco is for.Fix:
show_warehouse_wise_stock
is disabledTo test:
Show Warehouse Wise Stock
enabled in Report Stock AgeingShow Ageing Data
enabled