Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loan repayment via Salary Slip #29716

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Feb 8, 2022

The user gets the following error message while submitting salary slip with Loan paid via salary if the payroll payable account has account type as "Payable" due to missing party types in GL Entry

image

Steps to test:

  1. Create a Loan Type
  2. Create a loan against an employee and mark it as repay from Salary
  3. Create Loan Disbursement
  4. Process loan interest using Process Loan Interest Accrual Doctype
  5. Make a salary slip against that same employee, make sure the payroll payable account type is updated as "Payable"
  6. Try and submit the Salary Slip

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport develop

@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2022

backport develop

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@deepeshgarg007 deepeshgarg007 merged commit 90f5372 into frappe:version-13-hotfix Feb 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2022

backport develop

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Feb 12, 2022
fix: Loan repayment via Salary Slip (backport #29716)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant