Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show credit/debit-to account in error message #29699

Merged

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Feb 8, 2022

While creating Purchase/Sales Invoice, if Credit/Debit To Account doesn't have Account Type = Payable/Receivable, an error is thrown
Now, this error will now show the account name too.

CleanShot 2022-02-08 at 10 53 24

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #29699 (e93bb8a) into develop (780e29b) will increase coverage by 6.68%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop   #29699      +/-   ##
===========================================
+ Coverage    52.11%   58.80%   +6.68%     
===========================================
  Files         1108     1112       +4     
  Lines        69256    69467     +211     
===========================================
+ Hits         36094    40848    +4754     
+ Misses       33162    28619    -4543     
Impacted Files Coverage Δ
...ounts/doctype/purchase_invoice/purchase_invoice.py 82.29% <ø> (+6.84%) ⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 78.38% <0.00%> (+1.11%) ⬆️
...n/doctype/program_enrollment/program_enrollment.py 52.47% <100.00%> (+27.98%) ⬆️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 80.19% <0.00%> (-6.94%) ⬇️
erpnext/stock/reorder_item.py 74.35% <0.00%> (-3.42%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/support/doctype/issue/issue.py 64.56% <0.00%> (-0.98%) ⬇️
... and 218 more

@nextchamp-saqib nextchamp-saqib removed the needs-tests This PR needs automated unit-tests. label Feb 8, 2022
@nextchamp-saqib nextchamp-saqib merged commit 8eff296 into frappe:develop Feb 8, 2022
nextchamp-saqib added a commit that referenced this pull request Feb 8, 2022
…-29699

chore: show credit/debit-to account in error message (backport #29699)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant