Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Regenerate packed items on newly mapped doc #29642

Merged
merged 2 commits into from
Feb 4, 2022
Merged

fix: Regenerate packed items on newly mapped doc #29642

merged 2 commits into from
Feb 4, 2022

Conversation

marination
Copy link
Collaborator

@marination marination commented Feb 4, 2022 •
edited
Loading

Fixes #29634

Fix:

  • Cannot determine action on newly mapped DN (from SO) that hasn't been inserted
  • Rows could have been deleted, updated, added, etc. before first save
  • In this case , reset packing table
  • Should work as expected after fix
Screen.Recording.2022-02-04.at.10.19.04.PM.mov

@marination
fix: Regenerate packed items on newly mapped doc
bd41a99 
- Cannot determine action on newly mapped DN that hasnt been inserted
- Rows could have been deleted, updated, added, etc. before first save
- In this case , reset packing table
@marination marination added this to the v13.20 milestone Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022 •
edited
Loading

Codecov Report

Merging #29642 (bd41a99) into develop (65923bd) will increase coverage by 11.74%.
The diff coverage is 100.00%.

❗ Current head bd41a99 differs from pull request most recent head a49b755. Consider uploading reports for the commit a49b755 to get more accurate results

@@             Coverage Diff              @@
##           develop   #29642       +/-   ##
============================================
+ Coverage    47.16%   58.90%   +11.74%     
============================================
  Files         1108     1108               
  Lines        69292    69291        -1     
============================================
+ Hits         32681    40818     +8137     
+ Misses       36611    28473     -8138
Impacted Files Coverage Δ
erpnext/stock/doctype/packed_item/packed_item.py 87.02% <100.00%> (+0.65%) ⬆️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (ø)
...stock/doctype/purchase_receipt/purchase_receipt.py 90.88% <0.00%> (+0.25%) ⬆️
erpnext/accounts/deferred_revenue.py 76.19% <0.00%> (+0.43%) ⬆️
erpnext/accounts/report/tax_detail/tax_detail.py 89.89% <0.00%> (+0.50%) ⬆️
...ctype/stock_reconciliation/stock_reconciliation.py 83.14% <0.00%> (+0.57%) ⬆️
...cturing/doctype/production_plan/production_plan.py 69.24% <0.00%> (+0.58%) ⬆️
...rpnext/stock/report/stock_balance/stock_balance.py 79.76% <0.00%> (+0.59%) ⬆️
erpnext/controllers/buying_controller.py 87.02% <0.00%> (+0.70%) ⬆️
... and 237 more

@marination marination merged commit 772336b into frappe:develop Feb 4, 2022
@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify mergify bot mentioned this pull request Feb 4, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2022

backport version-13-hotfix

✅ Backports have been created

@mergify mergify bot mentioned this pull request Feb 4, 2022
Merged
marination added a commit that referenced this pull request Feb 4, 2022
@marination
Merge pull request #29645 from frappe/mergify/bp/version-13-hotfix/pr…
5bf994a 
…-29642

fix: Regenerate packed items on newly mapped doc (backport #29642)
marination added a commit that referenced this pull request Feb 4, 2022
@marination
Merge pull request #29646 from frappe/mergify/bp/version-13-pre-relea…
c99a14a 
…se/pr-29642

fix: Regenerate packed items on newly mapped doc (backport #29642)
@rohitwaghchaure rohitwaghchaure mentioned this pull request Feb 9, 2022
Merged
@rohitwaghchaure rohitwaghchaure mentioned this pull request Feb 21, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush Awaiting requested review from ankush

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
v13.20
Development

Successfully merging this pull request may close these issues.

Incorrect packing list calculation while updating quantity from SO --> DN
1 participant
@marination