Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore linked invoices on Journal Entry cancel #29641

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Feb 4, 2022

The user used to get below warning on canceling a Journal Entry that has been allocated to invoice as an Advance payment and the Sales Invoice also used to get canceled on canceling the Journal Entry

image

Only journal entry should be canceled and the invoice should be just delinked and not canceled.

Steps to test:

  1. Create an advance Journal Entry against a customer
  2. Create Sales Invoice against the same customer and allocate advance payment entry.
  3. Cancel the payment entry and check, Sales Invoice should not get canceled

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 3e6fade into frappe:develop Feb 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Feb 6, 2022
…-29641

fix: Ignore linked invoices on Journal Entry cancel (backport #29641)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant