fix(pos): pricing rule on transactions doesn't work #29597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2022
nextchamp-saqib
added a commit
that referenced
this pull request
Feb 2, 2022
…-29597 fix(pos): pricing rule on transactions doesn't work (backport #29597)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making a POS Invoice using POS UI, the invoice is not saved at any point. It is directly submitted with the "Submit Order" button.
This causes problems such as:
Such pricing rules are only applied when the invoice is saved. This behavior is the same across transactions.
For eg., if there is a pricing rule such that, a 10% discount is to be applied for a specific set of customers and if you try
to create a POS Invoice for one such customer, the discount will only be applied unless you click "Submit Order" at
Payment Page
Other similar issues have been fixed with this PR. Now, when a user clicks on "Checkout" before moving to the payment page, the invoice is first saved to set all the missing details